Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm deprecated warnings in logs #15512

Open
tarekoraby opened this issue Dec 16, 2022 · 6 comments
Open

npm deprecated warnings in logs #15512

tarekoraby opened this issue Dec 16, 2022 · 6 comments

Comments

@tarekoraby
Copy link
Contributor

Description of the bug

Running a freshly downloaded Flow or Hilla app, I see the following in the logs

npm WARN deprecated rollup-plugin-terser@7.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-terser
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead

Expected behavior

No warnings are shown when starting on the latest and greatest Vaadin version

Minimal reproducible example

Run a Flow or Hilla project from start.vaadin.com

Versions

  • Vaadin / Flow version: 23.3
  • Java version: 17
  • OS version: Windows 10
@Artur-
Copy link
Member

Artur- commented Dec 16, 2022

├─┬ workbox-build@6.5.0
│ ├─┬ rollup-plugin-terser@7.0.2

GoogleChrome/workbox#3136

├─┬ @rollup/plugin-replace@3.1.0
│ ├─┬ magic-string@0.25.9
│ │ └── sourcemap-codec@1.4.8
├─┬ @vitejs/plugin-react@2.2.0
│ ├─┬ magic-string@0.26.7
│ │ └── sourcemap-codec@1.4.8 deduped

@Artur-
Copy link
Member

Artur- commented Dec 16, 2022

magic-string was fixed in 0.27 a year ago...

@knoobie
Copy link
Contributor

knoobie commented Dec 16, 2022

Is workbox for anything used except service worker? If so, shouldn't this be only added if service worker / PWA annotation is used? I've seen this two warnings even for apps with no PWA support at all.

@tarekoraby
Copy link
Contributor Author

I can still see the warnings in the logs with 24.0.0.alpha8. The linked workbox issue is still not fixed.

@tarekoraby tarekoraby reopened this Jan 17, 2023
Artur- added a commit that referenced this issue May 31, 2023
Artur- added a commit that referenced this issue May 31, 2023
@Artur-
Copy link
Member

Artur- commented Jun 2, 2023

workbox is fixed in #16934 but transform-ast still depends on an old version of magic-string

@Artur-
Copy link
Member

Artur- commented Jun 27, 2023

Seems like a unreasonably large effort to get rid of all deprecation warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Normal Priority (P2)
Development

No branches or pull requests

5 participants