Paths with space fix #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows frequently has paths that include spaces. When invoking commands on the command-line with those paths, the items after the space are treated as parameters to the command line, instead of part of the path. Adding quotes around those commands fixes the issue.
- Removes repeated code from test implementation.
PEConn
approved these changes
Dec 5, 2019
src/lib/util.js
Outdated
| @@ -70,7 +70,8 @@ async function untar(tarFile, destinationPath, deleteZipWhenDone = false) { | |||
|
|
|||
| function execInteractive(cwd, args, env) { | |||
| const {spawn} = require('child_process'); | |||
| const shell = spawn(cwd, args, { | |||
| console.log(cwd); | |||
There was a problem hiding this comment.
Did you mean to leave this in?
There was a problem hiding this comment.
Nope. I actually noticed and removed already :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45