Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths with space fix #47

Merged
merged 4 commits into from
Dec 5, 2019
Merged

Paths with space fix #47

merged 4 commits into from
Dec 5, 2019

Commits on Dec 5, 2019

  1. Fixes some Windows build failing 

    Windows frequently has paths that include spaces. When invoking
commands on the command-line with those paths, the items after the
space are treated as parameters to the command line, instead of
part of the path. Adding quotes around those commands fixes the
issue.
    @andreban
    andreban committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    129eced View commit details
    Browse the repository at this point in the history

  2. Use appropriate path.join for each OS

    @andreban
    andreban committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    8b87555 View commit details
    Browse the repository at this point in the history

  3. Improves tests for AndroidSdkTools 

    - Removes repeated code from test implementation.
    @andreban
    andreban committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    579314b View commit details
    Browse the repository at this point in the history

  4. Removes dangling console.log

    @andreban
    andreban committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    fa63f1a View commit details
    Browse the repository at this point in the history