Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add insights card to RWS panel #141

Merged
merged 60 commits into from
Sep 25, 2023
Merged

Feature: Add insights card to RWS panel #141

merged 60 commits into from
Sep 25, 2023

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Sep 12, 2023 •
edited by maitreyie-chavan
Loading

Description

This PR includes code to add insights card inside the RWS panel. The insights card includes basic info showing whether a page is part of Related Website Sets alongside their primary domain and rationale.

Relevant Technical Choices

  • Using cli script to store RWS JSON file inside the extension.

Testing Instructions

  • Open https://hindustantimes.com or https://livemint.com, visit Site Boundaries -> Related Website Sets.
  • On the landing page, you'll see the text telling site being a part of RWS.
  • Open the RWS JSON file on the RWS repo and compare the presence of data inside that.

Additional Information:

Screenshot/Screencast

Screenshot 2023-09-15 at 4 27 19 PM Screenshot 2023-09-15 at 4 27 40 PM

Partially fixes #120

mayan-000 added 30 commits August 29, 2023 13:20
@mayan-000
Adds FPS panel and info card
7788f41
@mayan-000
Merge branch 'develop' into feat/fps
3cc4349
@mayan-000
Merge branch 'develop' into feat/fps
1c98f2c
@mayan-000
Add script to update RWS json from GH
e6d04dd
@mayan-000
Update Button props
6d78961
@mayan-000
Add utils functions to get rws insights
c787058
@mayan-000
Add Insights component
94f4b51
@mayan-000
Update RWS Panel with Insights
cbc4c80
@mayan-000
Update colors
07ea5e1
@mayan-000
Update type
da875c7
@mayan-000
Update testcase for checking insights util output
870782f
@mayan-000
Update insights tests
988a361
@mayan-000
Remove old component
21de754
@mayan-000
Add validation utils
4fe5c53
@mayan-000
Update types
7c124c2
@mayan-000
Add rws specific dumy components
c9175e4
@mayan-000
Add input elements for generator form
020aa6a
@mayan-000
Add util function to generate form output
343b898
@mayan-000
Add Form Output component
85ea45e
@mayan-000
Integrate input and add rws json generator to panel
5d7ae7b
@mayan-000
Update testcases for form
4f80bbc
@mayan-000
Merge branch 'develop' into feat/rws-1
9adcea3
@mayan-000
Update tests
40c1d65
@mayan-000
Merge branch 'feat/rws-1' into feat/rws-2
8bbe01d
@mayan-000
Updates UI and testcases
9a926b5
@mayan-000
Update select component
4e2d0a3
@mayan-000
Add icons for adding and removing
18f7dba
@mayan-000
Update UI
cfdc65c
@mayan-000
Add CTA to RWS repo pr url and pr form fork guide
8c865a2
@mayan-000
UI changes
e3b334e
@mayan-000 mayan-000 marked this pull request as ready for review September 15, 2023 11:46
@mayan-000 mayan-000 requested a review from mohdsayed September 15, 2023 11:46
@mayan-000 mayan-000 self-assigned this Sep 20, 2023
ayushnirwal
ayushnirwal approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@ayushnirwal ayushnirwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohdsayed mohdsayed merged commit 6cc0ddd into develop Sep 25, 2023
4 checks passed
@mohdsayed mohdsayed deleted the feat/rws-1 branch September 25, 2023 21:17
@maitreyie-chavan maitreyie-chavan linked an issue Sep 26, 2023 that may be closed by this pull request
Add Related Website Sets panel component #120
Closed
@mohdsayed mohdsayed mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushnirwal ayushnirwal ayushnirwal approved these changes

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@mayan-000 mayan-000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Related Website Sets panel component
3 participants
@mayan-000 @mohdsayed @ayushnirwal