Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move dashboard from design-system to report. #772

Merged
merged 28 commits into from
Jul 26, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Jul 24, 2024

Description

It was noted during building of tsc packages there was a circular dependency with the design-system and the library-detection which caused race condition during build process. This PR aims to solve this by moving the dashboard from design-system to the report package.

Relevant Technical Choices

Testing Instructions

For CLI:

  • Clone this branch. In the terminal run npm run build:all.
  • Now in CLI run npm run cli -- -u https://bbc.com
  • Open the report and download the report from the CLI dashboard.
  • It should open a similar report to the CLI-dashboard.

For extension:

  • Open the browser and install the PSAT extension zip.
  • Download the report from the browser.
  • Then download the report again from the dashboard, it should be similar to the report downloaded.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@amovar18 amovar18 self-assigned this Jul 24, 2024
Base automatically changed from fix/report-generation to develop July 24, 2024 09:28
@amovar18 amovar18 marked this pull request as ready for review July 24, 2024 10:51
@amovar18 amovar18 requested review from mohdsayed and mayan-000 July 24, 2024 10:51
@mohdsayed mohdsayed merged commit dc8a693 into develop Jul 26, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/build-errors branch July 26, 2024 09:50
@mohdsayed mohdsayed mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants