Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move dashboard from design-system to report. #772

Merged
merged 28 commits into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
9aba1ee
Remove report generation from webpack config.
amovar18 Jul 22, 2024
0343432
Fix report being generated from CLI.
amovar18 Jul 22, 2024
d527252
Fix report generation from extension and fix not reading cookie data …
amovar18 Jul 22, 2024
58efc95
Fix report download from extension report.
amovar18 Jul 23, 2024
e8e53bf
Add report to generated -o argument.
amovar18 Jul 23, 2024
f50b707
Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-too…
amovar18 Jul 23, 2024
ec5979d
Move getcurrentDateAndTime to common.
amovar18 Jul 23, 2024
38c68ef
Use getCurrentDateAndTime in report names.
amovar18 Jul 23, 2024
f7a8b5c
Enable report download when download
amovar18 Jul 23, 2024
ff15818
Fix qa feedback on report generation of extension.
amovar18 Jul 23, 2024
0d03558
Fix report generation in cli.
amovar18 Jul 23, 2024
cd279e3
Fix sitemap report generation.
amovar18 Jul 23, 2024
8ab02fc
Remove console.log
amovar18 Jul 23, 2024
e02d516
Fix sitemap naming convention.
amovar18 Jul 23, 2024
046d567
Add frames section and add icon to dashboard.
amovar18 Jul 23, 2024
260ccbd
Remove dashboard from design system and move it to report package.
amovar18 Jul 24, 2024
aece6aa
Fix report build.
amovar18 Jul 24, 2024
1ab43d4
Add report as dependency to cli-dashboard.
amovar18 Jul 24, 2024
f432aff
Fix build-errors.
amovar18 Jul 24, 2024
7680a9c
Fix ts build issues in report.
amovar18 Jul 24, 2024
453d903
Remove library-detection from dependency of design-system.
amovar18 Jul 24, 2024
2fe7f74
Fix report not defined error.
amovar18 Jul 24, 2024
8c1b8b9
Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-too…
amovar18 Jul 24, 2024
20599e9
Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-too…
amovar18 Jul 24, 2024
b8921ce
Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-too…
amovar18 Jul 25, 2024
b57a438
Fix build failing in report.
amovar18 Jul 25, 2024
8507cd1
Merge develop and resolve conflicts
mohdsayed Jul 26, 2024
70354f6
Avoid duplicate call of build:tsc-packages
mohdsayed Jul 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25,066 changes: 22,409 additions & 2,657 deletions package-lock.json

Large diffs are not rendered by default.

16 changes: 10 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"description": "Cookie Analysis Tool and CLI for analysis and understanding of cookie usage on web pages.",
"scripts": {
"build-storybook": "storybook build",
"build:all": "run-p build:cli build:ext",
"build:tsc-packages": "npm run build:i18n && npm run build:common && npm run build:design-system && npm run build:library-detection && npm run build:analysis-utils",
"dev:tsc-packages": "run-p dev:i18n dev:common dev:design-system dev:library-detection dev:analysis-utils",
"build:all": "run-p build:tsc-packages webpack:build:cli webpack:build:ext",
"build:tsc-packages": "npm run build:i18n && npm run build:common && npm run build:design-system && npm run build:library-detection && npm run build:analysis-utils && npm run build:report",
"dev:tsc-packages": "run-p dev:i18n dev:common dev:design-system dev:library-detection dev:analysis-utils dev:report",
"publish:all:local": "npm run build:all && npm run publish:local --workspaces",
"unpublish:all:local": "npm run unpublish:local --workspaces",
"publish:all:remote": "npm run build:all && npm run publish:remote --workspaces",
Expand All @@ -23,17 +23,19 @@
"dev:analysis-utils": "npm run dev -w @google-psat/analysis-utils",
"webpack:dev:cli": "npm run dev -w @google-psat/cli",
"dev:cli": "run-p dev:tsc-packages webpack:dev:cli",
"build:cli": "npm run build:tsc-packages && cross-env NODE_ENV=production npm run build -w @google-psat/cli",
"webpack:build:cli": "cross-env NODE_ENV=production npm run build -w @google-psat/cli",
"build:cli": "npm run build:tsc-packages && webpack:build:cli",
"build:cli:dashboard": "run-p build:cli build:cli-dashboard",
"cli": "node packages/cli/dist/main.js",
"build:report": "npm run dev -w @google-psat/report",
"build:report": "npm run build -w @google-psat/report",
"dev:report": "npm run dev -w @google-psat/report",
"dev:cli-dashboard": "npm run dev -w @google-psat/cli-dashboard",
"build:cli-dashboard": "cross-env NODE_ENV=production npm run build -w @google-psat/cli-dashboard",
"cookie-db:update": "node scripts/update-cookie-db.cjs",
"webpack:dev:ext":"npm run dev -w @google-psat/extension",
"dev:ext": "run-p dev:tsc-packages webpack:dev:ext",
"build:ext": "npm run build:tsc-packages && cross-env NODE_ENV=production npm run build -w @google-psat/extension",
"webpack:build:ext": "cross-env NODE_ENV=production npm run build -w @google-psat/extension",
"build:ext": "npm run build:tsc-packages && webpack:build:ext",
"lint": "npm-run-all --parallel lint:*",
"lint:js": "eslint .",
"lint:types": "tsc ",
Expand Down Expand Up @@ -149,5 +151,7 @@
"wappalyzer": {
"puppeteer": "^22.11.1"
}
},
"dependencies": {
}
}
1 change: 1 addition & 0 deletions packages/cli-dashboard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"@google-psat/common": "*",
"@google-psat/design-system": "*",
"@google-psat/i18n": "*",
"@google-psat/report": "*",
"react": "^18.2.0",
"react-dom": "^18.2.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-dashboard/src/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import {
extractCookies,
SiteMapReport,
SiteReport,
} from '@google-psat/design-system';
} from '@google-psat/report';

/**
* Internal dependencies
Expand Down
3 changes: 3 additions & 0 deletions packages/cli-dashboard/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
{ "path": "../common" },
{
"path": "../design-system"
},
{
"path": "../report"
}
]
}
1 change: 0 additions & 1 deletion packages/design-system/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
"dependencies": {
"@google-psat/common": "*",
"@google-psat/i18n": "*",
"@google-psat/library-detection": "*",
"classnames": "^2.3.2",
"file-saver": "^2.0.5",
"jszip": "^3.10.1",
Expand Down

This file was deleted.

1 change: 0 additions & 1 deletion packages/design-system/src/components/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export { default as MatrixComponentHorizontal } from './matrix/matrixComponent/m
export type { MatrixComponentProps } from './matrix/matrixComponent';
export { default as CookiesLanding } from './cookiesLanding';
export * from './cookiesLanding';
export * from './dashboard';
export { default as CookiesMatrix } from './cookiesLanding/cookiesMatrix';
export { default as CookieDetails } from './cookieDetails';
export { default as Details } from './cookieDetails/details';
Expand Down
1 change: 1 addition & 0 deletions packages/extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"@google-psat/design-system": "*",
"@google-psat/i18n": "*",
"@google-psat/library-detection": "*",
"@google-psat/report": "*",
"classnames": "^2.3.2",
"deep-object-diff": "^1.1.9",
"fast-xml-parser": "^4.3.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/extension/src/view/report/dashboardApp.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import type {
LibraryData,
} from '@google-psat/common';
import { I18n } from '@google-psat/i18n';
import { extractCookies, SiteReport } from '@google-psat/design-system';
import { extractCookies, SiteReport } from '@google-psat/report';

/**
* Internal dependencies
Expand Down
6 changes: 5 additions & 1 deletion packages/report/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
"name": "@google-psat/report",
"version": "0.9.0-2",
"description": "Static HTML analysis report",
"main": "dist/index.js",
"types": "dist-types/index.d.ts",
"repository": {
"type": "git",
"url": "https://github.com/GoogleChromeLabs/ps-analysis-tool",
Expand All @@ -18,7 +20,9 @@
"access": "public"
},
"scripts": {
"dev": "webpack serve --config ./webpack.config.cjs --open",
"build": "tsc",
"dev": "tsc-watch",
"build:remove": "rimraf dist dist-types tsconfig.tsbuildinfo",
"publish:local": "npm publish --registry=http://localhost:4873",
"publish:remote": "npm publish --access=public --registry=https://registry.npmjs.org",
"unpublish:local": "npm unpublish --registry=http://localhost:4873 --force",
Expand Down
3 changes: 0 additions & 3 deletions packages/report/src/app.css

This file was deleted.

89 changes: 0 additions & 89 deletions packages/report/src/app.tsx

This file was deleted.

Loading
Loading