Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: drop node target's key constraint requirement (#2068)" #2131

Conversation

fbiville
Copy link
Collaborator

This reverts commit 6804d64.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.61%. Comparing base (f933ae9) to head (9ad8cc8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rt/v2/neo4j/model/validation/NodeKeyValidator.java 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2131      +/-   ##
============================================
- Coverage     46.62%   46.61%   -0.01%     
- Complexity     3953     3954       +1     
============================================
  Files           867      868       +1     
  Lines         51567    51581      +14     
  Branches       5399     5401       +2     
============================================
+ Hits          24043    24047       +4     
- Misses        25808    25814       +6     
- Partials       1716     1720       +4     
Components Coverage Δ
spanner-templates 68.60% <ø> (-0.03%) ⬇️
spanner-import-export 65.54% <ø> (-0.08%) ⬇️
spanner-live-forward-migration 77.49% <ø> (ø)
spanner-live-reverse-replication 78.43% <ø> (ø)
spanner-bulk-migration 87.66% <ø> (ø)
Files with missing lines Coverage Δ
...rt/v2/neo4j/model/validation/NodeKeyValidator.java 78.57% <78.57%> (ø)

... and 3 files with indirect coverage changes

@fbiville
Copy link
Collaborator Author

fbiville commented Jan 13, 2025

Unrelated modules' tests fail in CI.

@liferoad liferoad merged commit 7147be4 into GoogleCloudPlatform:main Jan 13, 2025
14 of 16 checks passed
@fbiville fbiville deleted the neo4j/temporarily-bring-back-node-key-requirement branch January 14, 2025 10:42
pawankashyapollion pushed a commit to ollionorg/DataflowTemplates-fork that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants