Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: drop node target's key constraint requirement (#2068)" #2131

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
/*
* Copyright (C) 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations under
* the License.
*/
package com.google.cloud.teleport.v2.neo4j.model.validation;

import java.util.LinkedHashSet;
import java.util.Set;
import org.neo4j.importer.v1.targets.NodeTarget;
import org.neo4j.importer.v1.validation.SpecificationValidationResult.Builder;
import org.neo4j.importer.v1.validation.SpecificationValidator;

public class NodeKeyValidator implements SpecificationValidator {

private static final String ERROR_CODE = "DFNK-001";
private final Set<String> paths;

public NodeKeyValidator() {
this.paths = new LinkedHashSet<>();
}

@Override
public void visitNodeTarget(int index, NodeTarget target) {
var schema = target.getSchema();
if (schema == null) {
paths.add(String.format("$.targets.nodes[%d].schema.key_constraints", index));
return;

Check warning on line 38 in v2/googlecloud-to-neo4j/src/main/java/com/google/cloud/teleport/v2/neo4j/model/validation/NodeKeyValidator.java

View check run for this annotation

Codecov / codecov/patch

v2/googlecloud-to-neo4j/src/main/java/com/google/cloud/teleport/v2/neo4j/model/validation/NodeKeyValidator.java#L37-L38

Added lines #L37 - L38 were not covered by tests
}
if (schema.getKeyConstraints().isEmpty()) {
paths.add(String.format("$.targets.nodes[%d].schema.key_constraints", index));
}
}

@Override
public boolean report(Builder builder) {
paths.forEach(
path ->
builder.addError(
path, ERROR_CODE, String.format("%s must define at least 1 key constraint", path)));
return paths.isEmpty();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ com.google.cloud.teleport.v2.neo4j.model.validation.BigQuerySourceProjectDataset
com.google.cloud.teleport.v2.neo4j.model.validation.DuplicateAggregateFieldNameValidator
com.google.cloud.teleport.v2.neo4j.model.validation.DuplicateTextHeaderValidator
com.google.cloud.teleport.v2.neo4j.model.validation.InlineSourceDataValidator
com.google.cloud.teleport.v2.neo4j.model.validation.NodeKeyValidator
com.google.cloud.teleport.v2.neo4j.model.validation.TextColumnMappingValidator
com.google.cloud.teleport.v2.neo4j.model.validation.WriteModeValidator
com.google.cloud.teleport.v2.neo4j.model.validation.NodeMatchModeValidator
Loading