Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support legacy domain-scoped projects #150

Closed

Conversation

aniket486
Copy link

For example - google.com:project:region:instance-name

@kurtisvg
Copy link
Contributor

I was unaware that project names could even contain colons.

This doesn't really fix the problem, only one use case- if the user has multiple colons in the project name they will have the same problem.

@kurtisvg kurtisvg added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jul 25, 2019
@kurtisvg kurtisvg self-assigned this Jul 25, 2019
@kurtisvg
Copy link
Contributor

Digging into this a little more, it looks like project ids with a colon are "domain scoped", which is a legacy feature. It looks these projects only allow for one colon, so this fix could be suitable.

I need to confirm there isn't any existing precedence for this first.

@aniket486
Copy link
Author

@kurtisvg - any update on this?
You are right, there are a few legacy projects that have google.com: as a prefix. We need this change in order to support such projects.

@kurtisvg
Copy link
Contributor

Not yet - it looks like support for this is varied by product. GCR substitutes with a slash, Cloud Run just declares itself incompatible with domain scoped projects.

I'm waiting to hear back from the Cloud SQL team -- I want to make sure that whatever path we take is consistent with the proxy and Cloud SQL in other areas.

@kurtisvg kurtisvg changed the title Support instance connection names with ':' in projectId Support legacy domain-scoped projects Jul 30, 2019
@kurtisvg
Copy link
Contributor

kurtisvg commented Aug 1, 2019

It looks like the domain might be scoped only to the project name, and not the project_id. You should be able to already use the library with the "instance-connection-name" string provided on the Cloud SQL instance's overview page. Can you confirm that this works for you?

@kurtisvg
Copy link
Contributor

Ping on this - can I close this PR out or is it still needed?

@kurtisvg kurtisvg closed this Aug 27, 2019
@kurtisvg kurtisvg reopened this Dec 2, 2019
@kurtisvg
Copy link
Contributor

kurtisvg commented Dec 2, 2019

Just found another occurrence of a user that ran into this issue, as the Cloud SQL team was mistaken on what info is displayed for these users. I'm re-opening for now while investigating. Using #165 to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants