-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support legacy domain-scoped projects #150
Conversation
…google.com:project:region:instance-name
I was unaware that project names could even contain colons. This doesn't really fix the problem, only one use case- if the user has multiple colons in the project name they will have the same problem. |
Digging into this a little more, it looks like project ids with a colon are "domain scoped", which is a legacy feature. It looks these projects only allow for one colon, so this fix could be suitable. I need to confirm there isn't any existing precedence for this first. |
@kurtisvg - any update on this? |
Not yet - it looks like support for this is varied by product. GCR substitutes with a slash, Cloud Run just declares itself incompatible with domain scoped projects. I'm waiting to hear back from the Cloud SQL team -- I want to make sure that whatever path we take is consistent with the proxy and Cloud SQL in other areas. |
It looks like the domain might be scoped only to the project name, and not the project_id. You should be able to already use the library with the "instance-connection-name" string provided on the Cloud SQL instance's overview page. Can you confirm that this works for you? |
Ping on this - can I close this PR out or is it still needed? |
Just found another occurrence of a user that ran into this issue, as the Cloud SQL team was mistaken on what info is displayed for these users. I'm re-opening for now while investigating. Using #165 to track. |
For example - google.com:project:region:instance-name