Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for legacy domain-scoped projects. #209

Merged
merged 3 commits into from
Apr 7, 2020
Merged

Conversation

kurtisvg
Copy link
Contributor

@kurtisvg kurtisvg commented Apr 6, 2020

Allows users with legacy domain-scoped projects (e.g. "google.com:project_id:region:instance_id") to use this library.

@kurtisvg kurtisvg requested review from netdpb and shubha-rajan April 6, 2020 22:51
@kurtisvg
Copy link
Contributor Author

kurtisvg commented Apr 6, 2020

Fixes #165
Closes #150

@kurtisvg kurtisvg requested a review from netdpb April 7, 2020 16:21
@kurtisvg kurtisvg merged commit 20e1047 into master Apr 7, 2020
@kurtisvg kurtisvg deleted the domain-scope branch April 7, 2020 17:38
@kurtisvg kurtisvg mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants