Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tedious #66

Closed
ruyadorno opened this issue Mar 21, 2023 · 2 comments · Fixed by #125
Closed

Support tedious #66

ruyadorno opened this issue Mar 21, 2023 · 2 comments · Fixed by #125
Assignees
@ruyadorno
Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ruyadorno
Copy link
Contributor

Feature Description

Add support to SQLServer via the tedious driver. Should include e2e tests to validate support and update docs to showcase support and how to use.
@ruyadorno ruyadorno added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Mar 21, 2023
@ruyadorno ruyadorno added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Mar 21, 2023
@ruyadorno ruyadorno assigned ruyadorno and unassigned enocom Mar 21, 2023
@enocom enocom added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 23, 2023
@enocom
Copy link
Member

enocom commented Apr 25, 2023

@ruyadorno Would you mind linking to the associated PR?

@enocom
Copy link
Member

enocom commented May 9, 2023

tediousjs/tedious#1540

ruyadorno added a commit that referenced this issue May 17, 2023
@ruyadorno
refactor: move port value to cloud sql instance
442f0ad 
Moves the definition of the `port` value to CloudSQLInstance, allowing
it to be exposed to drivers that might need that value (such as
`tedious`) while also making it so that the `port` value is defined in
the same place as `host`.

Relates to: #66
@ruyadorno ruyadorno mentioned this issue May 17, 2023
Merged
@enocom enocom added priority: p0 Highest priority. Critical issue. P0 implies highest priority. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 17, 2023
ruyadorno added a commit that referenced this issue May 17, 2023
@ruyadorno
refactor: move port value to cloud sql instance
2759fa0 
Moves the definition of the `port` value to CloudSQLInstance, allowing
it to be exposed to drivers that might need that value (such as
`tedious`) while also making it so that the `port` value is defined in
the same place as `host`.

Relates to: #66
ruyadorno added a commit that referenced this issue May 19, 2023
@ruyadorno
feat: add sqlserver support
567dacd 
This changeset introduces a new API to support SQLServer via the
`tedious` driver along with end-to-end tests and base README
documentation on how to use the connector with a SQLServer Cloud SQL
instance.

Fixes: #66
@ruyadorno ruyadorno mentioned this issue May 19, 2023
Merged
ruyadorno added a commit that referenced this issue May 25, 2023
@ruyadorno
feat: add sqlserver support
31c3828 
This changeset introduces a new API to support SQLServer via the
`tedious` driver along with end-to-end tests and base README
documentation on how to use the connector with a SQLServer Cloud SQL
instance.

Fixes: #66
ruyadorno added a commit that referenced this issue May 25, 2023
@ruyadorno
feat: add sqlserver support
fe972d0 
This changeset introduces a new API to support SQLServer via the
`tedious` driver along with end-to-end tests and base README
documentation on how to use the connector with a SQLServer Cloud SQL
instance.

Fixes: #66
ruyadorno added a commit that referenced this issue May 25, 2023
@ruyadorno
feat: add sqlserver support
5342875 
This changeset introduces a new API to support SQLServer via the
`tedious` driver along with end-to-end tests and base README
documentation on how to use the connector with a SQLServer Cloud SQL
instance.

Fixes: #66
ruyadorno added a commit that referenced this issue May 25, 2023
@ruyadorno
feat: add sqlserver support
a2546bb 
This changeset introduces a new API to support SQLServer via the
`tedious` driver along with end-to-end tests and base README
documentation on how to use the connector with a SQLServer Cloud SQL
instance.

Fixes: #66
ruyadorno added a commit that referenced this issue May 26, 2023
@ruyadorno
feat: add sqlserver support
1c57b9a 
This changeset introduces a new API to support SQLServer via the
`tedious` driver along with end-to-end tests and base README
documentation on how to use the connector with a SQLServer Cloud SQL
instance.

Fixes: #66
ruyadorno added a commit that referenced this issue May 26, 2023
@ruyadorno
feat: add sqlserver support
ab3dc67 
This changeset introduces a new API to support SQLServer via the
`tedious` driver along with end-to-end tests and base README
documentation on how to use the connector with a SQLServer Cloud SQL
instance.

Fixes: #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruyadorno ruyadorno

Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add sqlserver support GoogleCloudPlatform/cloud-sql-nodejs-connector
2 participants
@ruyadorno @enocom