Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sqlserver support #125

Merged
merged 1 commit into from
May 26, 2023
Merged

feat: add sqlserver support #125

merged 1 commit into from
May 26, 2023

Conversation

ruyadorno
Copy link
Contributor

This changeset introduces a new API to support SQLServer via the tedious driver along with end-to-end tests and base README documentation on how to use the connector with a SQLServer Cloud SQL instance.

Fixes: #66

@ruyadorno ruyadorno marked this pull request as ready for review May 25, 2023 01:35
@ruyadorno ruyadorno requested a review from a team as a code owner May 25, 2023 01:35
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A few comments.

README.md Show resolved Hide resolved
src/connector.ts Show resolved Hide resolved
system-test/tedious-connect.cjs Outdated Show resolved Hide resolved
system-test/tedious-connect.cjs Show resolved Hide resolved
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A few comments.

@ruyadorno ruyadorno force-pushed the add-support-to-sqlserver branch 2 times, most recently from 5342875 to a2546bb Compare May 25, 2023 20:36
This changeset introduces a new API to support SQLServer via the
`tedious` driver along with end-to-end tests and base README
documentation on how to use the connector with a SQLServer Cloud SQL
instance.

Fixes: #66
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@enocom enocom self-requested a review May 26, 2023 17:08
@ruyadorno ruyadorno merged commit ab3dc67 into main May 26, 2023
@ruyadorno ruyadorno deleted the add-support-to-sqlserver branch May 26, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tedious
3 participants