Add AckDeadlineRenewer class for automatic ack deadline renewal #1031

mziccard · 2016-05-27T16:56:51Z

This is a simpler version of #1024 to provide support for automatic ack deadline renewals

coveralls · 2016-05-27T19:47:22Z

Coverage increased (+0.002%) to 84.294% when pulling 01dbb40 on mziccard:pubsub-renewer into b872399 on GoogleCloudPlatform:pubsub-alpha.

mziccard · 2016-05-27T20:43:04Z

/cc @aozarov

gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/AckDeadlineRenewer.java

+ * {@link #add(String, Iterable)}. The acknowledge deadlines of added messages are renewed until the
+ * messages are explicitly removed using {@link #remove(String, String)}.
+ */
+class AckDeadlineRenewer implements AutoCloseable {


mziccard · 2016-06-01T15:56:33Z

@aozarov In d4b8f6c I refactored the tests to follow your suggestion. I also addressed other comments. I removed the fixed interval and now renewer is only scheduled when actually needed. PTAL

coveralls · 2016-06-01T16:13:12Z

Coverage increased (+0.3%) to 84.609% when pulling d4b8f6c on mziccard:pubsub-renewer into b872399 on GoogleCloudPlatform:pubsub-alpha.

coveralls · 2016-06-01T22:12:04Z

Coverage increased (+0.3%) to 84.608% when pulling 501ba7d on mziccard:pubsub-renewer into b872399 on GoogleCloudPlatform:pubsub-alpha.

gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/AckDeadlineRenewer.java

+    }
+    for (Map.Entry<String, List<String>> entry : Multimaps.asMap(messagesToRenewNext).entrySet()) {
+      // We send all ack deadline renewals for a subscription
+      pubsub.modifyAckDeadlineAsync(entry.getKey(), MIN_DEADLINE_MILLIS,


aozarov · 2016-06-01T22:29:07Z

Change looks good. Implementation looks good and api looks good (I provided one more minor suggestion). Maybe @lesv want to go over this code as well (I didn't pay attention to anything but API and impl).

gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/PubSubOptions.java

@@ -86,6 +86,11 @@ protected PubSubOptions(Builder builder) {
  }

  @Override
+  protected ExecutorFactory executorFactory() {


coveralls · 2016-06-02T20:56:31Z

Coverage increased (+0.7%) to 84.977% when pulling 386269e on mziccard:pubsub-renewer into b872399 on GoogleCloudPlatform:pubsub-alpha.

mziccard · 2016-06-03T10:41:59Z

I am merging this, if @lesv has some more comments I'd be happy to address them in separate PRs.

lesv · 2016-06-06T16:55:30Z

I'm happy with this change.

…leapis#1031) * Add AckDeadlineRenewer class for automatic ack deadline renewal * Refactor renewer tests and wake up renewer only when needed * Skip removed/re-added messages when scheduling new renewal * Better tuning of ack deadline in renewer

…14.7 (#1031)

🤖 I have created a release *beep* *boop* --- ## [3.3.0](googleapis/java-aiplatform@v3.2.0...v3.3.0) (2022-09-15) ### Features * add input_artifacts to PipelineJob.runtime_config in aiplatform v1 pipeline_job ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab)) * Add model_monitoring_stats_anomalies,model_monitoring_status to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto ([#1041](googleapis/java-aiplatform#1041)) ([fe03c60](googleapis/java-aiplatform@fe03c60)) * Add read_mask to ListPipelineJobsRequest in aiplatform v1 pipeline_service ([#1032](googleapis/java-aiplatform#1032)) ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab)) * Add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1 index_service.proto ([#1030](googleapis/java-aiplatform#1030)) ([4114021](googleapis/java-aiplatform@4114021)) * add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1beta1 index_service.proto ([4114021](googleapis/java-aiplatform@4114021)) * Add WriteFeatureValues in aiplatform v1beta1 featurestore_online_service.proto ([#1022](googleapis/java-aiplatform#1022)) ([267827e](googleapis/java-aiplatform@267827e)) ### Dependencies * Update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.18.0 ([#1021](googleapis/java-aiplatform#1021)) ([c3d34a0](googleapis/java-aiplatform@c3d34a0)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#1016](googleapis/java-aiplatform#1016)) ([cc0af7b](googleapis/java-aiplatform@cc0af7b)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#1026](googleapis/java-aiplatform#1026)) ([6ed66cc](googleapis/java-aiplatform@6ed66cc)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#1031](googleapis/java-aiplatform#1031)) ([5adefd4](googleapis/java-aiplatform@5adefd4)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#1040](googleapis/java-aiplatform#1040)) ([b6c1b20](googleapis/java-aiplatform@b6c1b20)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#1044](googleapis/java-aiplatform#1044)) ([5ce52e5](googleapis/java-aiplatform@5ce52e5)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1043](googleapis/java-aiplatform#1043)) ([40eae55](googleapis/java-aiplatform@40eae55)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1045](googleapis/java-aiplatform#1045)) ([0f66302](googleapis/java-aiplatform@0f66302)) * Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#1015](googleapis/java-aiplatform#1015)) ([7a2fcb0](googleapis/java-aiplatform@7a2fcb0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…telligence-bom to v2.2.10 (#1031) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-video-intelligence-bom](https://togithub.com/googleapis/java-video-intelligence) | `2.2.7` -> `2.2.10` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence-bom/2.2.10/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence-bom/2.2.10/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence-bom/2.2.10/compatibility-slim/2.2.7)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence-bom/2.2.10/confidence-slim/2.2.7)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…1.3 (#1031) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/compatibility-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/confidence-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-vision).

* chore: remove samples files due migration * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

….6.12 (#1031)

mziccard added the api: pubsub Issues related to the Pub/Sub API. label May 27, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2016

mziccard mentioned this pull request May 27, 2016

Add AckDeadlineRenewer and AckDeadlineRenewerImpl classes #1024

Closed

mziccard force-pushed the pubsub-renewer branch 2 times, most recently from 681108a to d4f296e Compare May 27, 2016 18:59

Add AckDeadlineRenewer class for automatic ack deadline renewal

01dbb40

mziccard force-pushed the pubsub-renewer branch from d4f296e to 01dbb40 Compare May 27, 2016 19:41

aozarov reviewed May 31, 2016
View reviewed changes

Refactor renewer tests and wake up renewer only when needed

d4b8f6c

Skip removed/re-added messages when scheduling new renewal

501ba7d

aozarov reviewed Jun 1, 2016
View reviewed changes

Better tuning of ack deadline in renewer

386269e

mziccard reviewed Jun 2, 2016
View reviewed changes

mziccard merged commit e3a6d2e into googleapis:pubsub-alpha Jun 3, 2016

mziccard mentioned this pull request Aug 12, 2016

Pub/Sub unit tests are slow #1159

Closed

github-actions bot pushed a commit that referenced this pull request Aug 24, 2022

deps: update dependency com.google.cloud:google-cloud-bigquery to v2.…

5adefd4

…14.7 (#1031)

release-please bot mentioned this pull request Aug 24, 2022

chore: release monorepo_script_output #8199

Closed

release-please bot mentioned this pull request Aug 26, 2022

chore: release main #8222

Closed

release-please bot mentioned this pull request Sep 23, 2022

chore: release main #8444

Closed

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update dependency com.google.api.grpc:proto-google-iam-v1 to v1…

2983a65

….6.12 (#1031)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AckDeadlineRenewer class for automatic ack deadline renewal #1031

Add AckDeadlineRenewer class for automatic ack deadline renewal #1031

mziccard commented May 27, 2016

coveralls commented May 27, 2016

mziccard commented May 27, 2016

This comment was marked as spam.

mziccard commented Jun 1, 2016

coveralls commented Jun 1, 2016

coveralls commented Jun 1, 2016

This comment was marked as spam.

aozarov commented Jun 1, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Jun 2, 2016

mziccard commented Jun 3, 2016

lesv commented Jun 6, 2016

Add AckDeadlineRenewer class for automatic ack deadline renewal #1031

Add AckDeadlineRenewer class for automatic ack deadline renewal #1031

Conversation

mziccard commented May 27, 2016

coveralls commented May 27, 2016

mziccard commented May 27, 2016

This comment was marked as spam.

mziccard commented Jun 1, 2016

coveralls commented Jun 1, 2016

coveralls commented Jun 1, 2016

This comment was marked as spam.

aozarov commented Jun 1, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Jun 2, 2016

mziccard commented Jun 3, 2016

lesv commented Jun 6, 2016