Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: create delete list integration tests #1073

Merged
merged 24 commits into from
Apr 27, 2023
Merged

Fix: create delete list integration tests #1073

merged 24 commits into from
Apr 27, 2023

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Apr 25, 2023 •
edited
Loading

This will be pull request template

Description

Fix:

  • Separate Create and Delete flows
  • CreateObjectTest - Updating name
  • DeleteObjectTest - Updating name
  • List Test - Updating condition from && to || (as any condition fails, it should fail)
  • Updating const variable name

Link to the issue in case of a bug fix.

Testing details

  1. Manual - all the integration tests are passing
  2. Unit tests - N/A
  3. Integration tests - All the integration tests are passing in integration tests dir

@Tulsishah Tulsishah changed the title [Don't Review] Fix create delete list integration tests Fix: create delete list integration tests Apr 25, 2023
sethiay
sethiay approved these changes Apr 26, 2023
View reviewed changes
tools/integration_tests/readonly/list_objects_test.go Outdated Show resolved Hide resolved
tools/integration_tests/readonly/list_objects_test.go Outdated Show resolved Hide resolved
tools/integration_tests/readonly/list_objects_test.go Outdated Show resolved Hide resolved
tools/integration_tests/readonly/list_objects_test.go Outdated Show resolved Hide resolved
@Tulsishah Tulsishah merged commit 3918ded into GoogleCloudPlatform:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadlakondaswetha vadlakondaswetha vadlakondaswetha approved these changes

@sethiay sethiay sethiay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tulsishah @sethiay @vadlakondaswetha