Fix: create delete list integration tests

tools/integration_tests/readonly/create_object_test.go

@@ -0,0 +1,71 @@
+// Copyright 2023 Google Inc. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Provides integration tests for file operations with --o=ro flag set.
+package readonly_test
+
+import (
+	"io/fs"
+	"os"
+	"path"
+	"testing"
+
+	"github.com/googlecloudplatform/gcsfuse/tools/integration_tests/setup"
+)
+
+func checkIfFileCreationFailed(filePath string, t *testing.T) {
+	file, err := os.OpenFile(filePath, os.O_CREATE, setup.FilePermission_0600)
+
+	if err == nil {
+		t.Errorf("File is created in read-only file system.")
+	}
+
+	checkErrorForReadOnlyFileSystem(err, t)
+
+	defer file.Close()
+}
+
+func TestCreateFile(t *testing.T) {
+	filePath := path.Join(setup.MntDir(), "testFile.txt")
+
+	checkIfFileCreationFailed(filePath, t)
+}
+
+func TestCreateFileInDirectory(t *testing.T) {
+	filePath := path.Join(setup.MntDir(), DirectoryNameInTestBucket, "testFile.txt")
+
+	checkIfFileCreationFailed(filePath, t)
+}
+
+func checkIfDirCreationFailed(dirPath string, t *testing.T) {
+	err := os.Mkdir(dirPath, fs.ModeDir)
+
+	if err == nil {
+		t.Errorf("Directory is created in read-only file system.")
+	}
+
+	checkErrorForReadOnlyFileSystem(err, t)
+}
+
+func TestCreateDir(t *testing.T) {
+	dirPath := path.Join(setup.MntDir(), "test")
+
+	checkIfDirCreationFailed(dirPath, t)
+}
+
+func TestCreateSubDirectoryInDirectory(t *testing.T) {
+	dirPath := path.Join(setup.MntDir(), DirectoryNameInTestBucket, "test")
+
+	checkIfDirCreationFailed(dirPath, t)
+}

tools/integration_tests/readonly/delete_object_test.go

@@ -0,0 +1,62 @@
+// Copyright 2023 Google Inc. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Provides integration tests for file operations with --o=ro flag set.
+package readonly_test
+
+import (
+	"os"
+	"path"
+	"testing"
+
+	"github.com/googlecloudplatform/gcsfuse/tools/integration_tests/setup"
+)
+
+func checkIfObjDeletionFailed(objPath string, t *testing.T) {
+	err := os.RemoveAll(objPath)
+
+	if err == nil {
+		t.Errorf("Objects are deleted in read-only file system.")
+	}
+
+	checkErrorForReadOnlyFileSystem(err, t)
+}
+
+func TestDeleteDir(t *testing.T) {
+	objPath := path.Join(setup.MntDir(), DirectoryNameInTestBucket)
+
+	checkIfObjDeletionFailed(objPath, t)
+}
+
+func TestDeleteFile(t *testing.T) {
+	objPath := path.Join(setup.MntDir(), FileNameInTestBucket)
+
+	checkIfObjDeletionFailed(objPath, t)
+}
+
+func TestDeleteSubDirectory(t *testing.T) {
+	objPath := path.Join(setup.MntDir(), DirectoryNameInTestBucket, SubDirectoryNameInTestBucket)
+
+	checkIfObjDeletionFailed(objPath, t)
+}
+
+func TestDeleteFileInDirectory(t *testing.T) {
+	objPath := path.Join(setup.MntDir(), DirectoryNameInTestBucket, FileNameInDirectoryTestBucket)
+
+	checkIfObjDeletionFailed(objPath, t)
+}
+
+func TestDeleteAllObjectsInBucket(t *testing.T) {
+	checkIfObjDeletionFailed(setup.MntDir(), t)
+}

tools/integration_tests/readonly/list_objects_test.go

@@ -35,20 +35,25 @@ func TestListObjectsInBucket(t *testing.T) {
 		log.Fatal(err)
 	}
 
+	// Comparing number of objects in the testBucket - 2
 	if len(obj) != NumberOfObjectsInTestBucket {
 		t.Errorf("The number of objects in the current directory doesn't match.")
 	}
 
-	if obj[0].Name() != DirectoryNameInTestBucket && obj[0].IsDir() != true {
+	// Comparing first object name and type
+	// Name - testBucket/Test, Type - Dir
+	if obj[0].Name() != DirectoryNameInTestBucket || obj[0].IsDir() != true {
 		t.Errorf("Listed object is incorrect.")
 	}
 
-	if obj[1].Name() != FileNameInTestBucket && obj[1].IsDir() != false {
+	// Comparing second object name and type
+	// Name - testBucket/Test1.txt, Type - File
+	if obj[1].Name() != FileNameInTestBucket || obj[1].IsDir() != false {
 		t.Errorf("Listed object is incorrect.")
 	}
 }
 
-func TestListObjectsInBucketSubDirectory(t *testing.T) {
+func TestListObjectsInBucketDirectory(t *testing.T) {
 	// ** SubDirectory structure **
 	// testBucket/Test
 	// testBucket/Test/a.txt -- File
@@ -60,15 +65,20 @@ func TestListObjectsInBucketSubDirectory(t *testing.T) {
 		log.Fatal(err)
 	}
 
-	if len(obj) != NumberOfObjectsInTestBucketSubDirectory {
+	// Comparing number of objects in the directory of testBucket - 2.
+	if len(obj) != NumberOfObjectsInDirectoryTestBucket {
 		t.Errorf("The number of objects in the current directory doesn't match.")
 	}
 
-	if obj[0].Name() != FileInSubDirectoryNameInTestBucket && obj[0].IsDir() != false {
-		t.Errorf("Listed object is incorrect.")
+	// Comparing first object name and type.
+	// Name - testBucket/Test/a.txt, Type - File
+	if obj[0].Name() != FileNameInDirectoryTestBucket || obj[0].IsDir() != false {
+		t.Errorf("Listed object from bucket directory is incorrect.")
 	}
 
-	if obj[1].Name() != SubDirectoryNameInTestBucket && obj[1].IsDir() != true {
-		t.Errorf("Listed object is incorrect.")
+	// Comparing second object name and type.
+	// Name - testBucket/b, Type - Dir
+	if obj[1].Name() != SubDirectoryNameInTestBucket || obj[1].IsDir() != true {
+		t.Errorf("Listed object from bucket directory is incorrect.")
 	}
 }

tools/integration_tests/readonly/readonly_test.go

@@ -18,17 +18,19 @@ package readonly_test
 import (
 	"os"
 	"os/exec"
+	"strings"
 	"testing"
 
 	"github.com/googlecloudplatform/gcsfuse/tools/integration_tests/setup"
 )
 
-const DirectoryNameInTestBucket = "Test"           //  testBucket/Test
-const FileNameInTestBucket = "Test1.txt"           //  testBucket/Test1.txt
-const SubDirectoryNameInTestBucket = "b"           //  testBucket/Test/b
-const FileInSubDirectoryNameInTestBucket = "a.txt" //  testBucket/Test/a.txt
+const DirectoryNameInTestBucket = "Test"         //  testBucket/Test
+const FileNameInTestBucket = "Test1.txt"         //  testBucket/Test1.txt
+const SubDirectoryNameInTestBucket = "b"         //  testBucket/Test/b
+const FileNameInDirectoryTestBucket = "a.txt"    //  testBucket/Test/a.txt
+const FileNameInSubDirectoryTestBucket = "b.txt" //  testBucket/Test/b/b.txt
 const NumberOfObjectsInTestBucket = 2
-const NumberOfObjectsInTestBucketSubDirectory = 2
+const NumberOfObjectsInDirectoryTestBucket = 2
 
 // Run shell script
 func runScriptForTestData(script string, testBucket string) {
@@ -39,6 +41,12 @@ func runScriptForTestData(script string, testBucket string) {
 	}
 }
 
+func checkErrorForReadOnlyFileSystem(err error, t *testing.T) {
+	if !strings.Contains(err.Error(), "read-only file system") && !strings.Contains(err.Error(), "permission denied") {
+		t.Errorf("Incorrect error for readonly filesystem.")
+	}
+}
+
 func TestMain(m *testing.M) {
 	setup.ParseSetUpFlags()