Rename log rotate config #1520
Merged
Rename log rotate config #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmeenkaur
force-pushed
the
rename-log-rotate-config
branch
from
b607b11
to
90d1dc7
Compare
ashmeenkaur
changed the base branch from
dec_2023_release
to
integrate_with_lumberjack
ashmeenkaur
force-pushed
the
rename-log-rotate-config
branch
from
73574b3
to
ccc7829
Compare
ashmeenkaur
changed the base branch from
integrate_with_lumberjack
to
dec_2023_release
ashmeenkaur
requested review from
sethiay,
vadlakondaswetha and
raj-prince
as code owners
raj-prince
requested changes
Nov 25, 2023
raj-prince
reviewed
Nov 27, 2023
raj-prince
requested changes
Nov 27, 2023
Added a TODO for the same, I will take this up in a separate PR. |
raj-prince
approved these changes
Nov 27, 2023
gargnitingoogle
pushed a commit
that referenced
this pull request
Nov 28, 2023
* change file-count to backup-file-count * remove 0 value constraint from backup-file-count * review comment to add unit test for backup file count 0 * review comments
gargnitingoogle
pushed a commit
that referenced
this pull request
Nov 28, 2023
* change file-count to backup-file-count * remove 0 value constraint from backup-file-count * review comment to add unit test for backup file count 0 * review comments
gargnitingoogle
pushed a commit
that referenced
this pull request
Nov 28, 2023
* change file-count to backup-file-count * remove 0 value constraint from backup-file-count * review comment to add unit test for backup file count 0 * review comments
gargnitingoogle
pushed a commit
that referenced
this pull request
Nov 29, 2023
* change file-count to backup-file-count * remove 0 value constraint from backup-file-count * review comment to add unit test for backup file count 0 * review comments
raj-prince
pushed a commit
that referenced
this pull request
Nov 29, 2023
* change file-count to backup-file-count * remove 0 value constraint from backup-file-count * review comment to add unit test for backup file count 0 * review comments
gargnitingoogle
pushed a commit
that referenced
this pull request
Jan 4, 2024
* change file-count to backup-file-count * remove 0 value constraint from backup-file-count * review comment to add unit test for backup file count 0 * review comments
ashmeenkaur
added a commit
that referenced
this pull request
Jan 9, 2024
* change file-count to backup-file-count * remove 0 value constraint from backup-file-count * review comment to add unit test for backup file count 0 * review comments
ashmeenkaur
added a commit
that referenced
this pull request
Jan 10, 2024
* change file-count to backup-file-count * remove 0 value constraint from backup-file-count * review comment to add unit test for backup file count 0 * review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the limitation in lumberjack library that doesn't allow creation of 0 backup files, we are renaming "file-count" config to "backup-file-count".
Link to the issue in case of a bug fix.
Testing details