Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing-on-gke future] Add tests for serving scenario #2322

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[testing-on-gke future] Add tests for serving scenario #2322

merged 1 commit into from
Sep 20, 2024

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Aug 8, 2024 •
edited
Loading

Description

This adds test workload specific to serving workload in gke test setup tool.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 3.1] Add tests for serving scenario [testing-on-gke part 4] Add tests for serving scenario Aug 8, 2024
@gargnitingoogle gargnitingoogle mentioned this pull request Aug 8, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.07%. Comparing base (c415a6a) to head (1ebc2f5).

Additional details and impacted files 
@@                               Coverage Diff                                @@
##           garnitin/add-gke-load-testing/add-run-script/v2    #2322   +/-   ##
================================================================================
  Coverage                                            79.07%   79.07%           
================================================================================
  Files                                                  105      105           
  Lines                                                11577    11577           
================================================================================
  Hits                                                  9155     9155           
  Misses                                                1958     1958           
  Partials                                               464      464
Flag Coverage Δ
unittests 79.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gargnitingoogle gargnitingoogle marked this pull request as ready for review August 9, 2024 05:34
@gargnitingoogle gargnitingoogle requested review from Tulsishah and a team as code owners August 9, 2024 05:34
@gargnitingoogle gargnitingoogle requested review from kislaykishore and removed request for a team August 9, 2024 05:34
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from df1d830 to f93aa87 Compare August 9, 2024 15:33
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from 7dd4d11 to 60e0399 Compare August 9, 2024 15:34
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from f93aa87 to fdfc07a Compare August 12, 2024 04:21
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from 60e0399 to 5ae8b2d Compare August 12, 2024 04:21
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from fdfc07a to 2d7028e Compare August 12, 2024 06:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch 2 times, most recently from af084e7 to e57a3c9 Compare August 12, 2024 09:02
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from 2eadd4b to e245d62 Compare August 14, 2024 10:48
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from e57a3c9 to 4d3c974 Compare August 14, 2024 10:49
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch 2 times, most recently from 1576c15 to 6fd5de1 Compare August 19, 2024 06:06
@gargnitingoogle gargnitingoogle mentioned this pull request Aug 19, 2024
Merged
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from 4d3c974 to e671e3e Compare August 19, 2024 07:31
@gargnitingoogle gargnitingoogle changed the base branch from garnitin/add-gke-load-testing/support-special-cases/v1 to garnitin/add-gke-load-testing/add-run-script/v2 August 19, 2024 07:32
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from 2fec539 to 2ec75eb Compare August 19, 2024 09:01
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from e671e3e to 425ea88 Compare August 19, 2024 09:03
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from 2ec75eb to a4552be Compare August 19, 2024 15:14
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from 425ea88 to db5a2e7 Compare August 19, 2024 15:16
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from a4552be to 04af62c Compare August 20, 2024 05:45
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from db5a2e7 to 424074c Compare August 20, 2024 05:47
@gargnitingoogle gargnitingoogle changed the base branch from garnitin/add-gke-load-testing/code-cleanup/v1 to garnitin/add-gke-load-testing/improvements-in-run-script September 17, 2024 10:43
@gargnitingoogle gargnitingoogle mentioned this pull request Sep 17, 2024
Merged
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from 2d72ed3 to b94e91f Compare September 18, 2024 06:25
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from 8985e2d to a5812fd Compare September 18, 2024 06:25
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from b94e91f to 58948ee Compare September 18, 2024 06:53
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch 2 times, most recently from 5a69f28 to 896f47b Compare September 18, 2024 06:57
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from b92fa47 to 0364b7c Compare September 18, 2024 08:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from 896f47b to 97aaa7c Compare September 18, 2024 08:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from 0364b7c to 9613a45 Compare September 18, 2024 08:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from 97aaa7c to a28133b Compare September 18, 2024 08:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from 9613a45 to 302395c Compare September 18, 2024 08:41
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from a28133b to 1c675cb Compare September 18, 2024 08:41
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from 302395c to 5cad921 Compare September 18, 2024 08:55
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from 1c675cb to cf49a39 Compare September 18, 2024 08:55
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from 5cad921 to 5369f22 Compare September 18, 2024 17:19
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from cf49a39 to c18b8ea Compare September 18, 2024 17:20
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from 5369f22 to e7c70ad Compare September 18, 2024 17:31
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch 2 times, most recently from 3ca43c3 to 2a8b7c8 Compare September 19, 2024 16:49
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from e7c70ad to bdc69dc Compare September 19, 2024 16:49
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-serving-tests/v1 branch from 2a8b7c8 to 571446e Compare September 19, 2024 17:02
@gargnitingoogle gargnitingoogle changed the base branch from garnitin/add-gke-load-testing/improvements-in-run-script to master September 19, 2024 17:03
@kislaykishore kislaykishore requested a review from a team September 19, 2024 17:10
@gargnitingoogle gargnitingoogle merged commit 60f592d into master Sep 20, 2024
4 checks passed
@gargnitingoogle gargnitingoogle deleted the garnitin/add-gke-load-testing/add-serving-tests/v1 branch September 20, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charith87 charith87 charith87 approved these changes

@Tulsishah Tulsishah Tulsishah approved these changes

@kislaykishore kislaykishore Awaiting requested review from kislaykishore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gargnitingoogle @kislaykishore @charith87 @Tulsishah