-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testing-on-gke part 6.7] Improvements in run script #2498
Merged
gargnitingoogle
merged 29 commits into
master
from
garnitin/add-gke-load-testing/improvements-in-run-script
Oct 10, 2024
Merged
[testing-on-gke part 6.7] Improvements in run script #2498
gargnitingoogle
merged 29 commits into
master
from
garnitin/add-gke-load-testing/improvements-in-run-script
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
2 times, most recently
from
September 17, 2024 07:09
69dd733
to
06df415
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enforce-one-pod-per-node
branch
from
September 17, 2024 07:10
b77d5ef
to
bf0661a
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
September 17, 2024 10:18
06df415
to
fb05a44
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enforce-one-pod-per-node
branch
2 times, most recently
from
September 17, 2024 10:30
c49f080
to
ac9c164
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
September 17, 2024 10:30
fb05a44
to
2d72ed3
Compare
gargnitingoogle
requested review from
kislaykishore
and removed request for
a team
September 17, 2024 10:37
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enforce-one-pod-per-node
branch
from
September 18, 2024 06:25
ac9c164
to
4d3d3fb
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
September 18, 2024 06:25
2d72ed3
to
b94e91f
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enforce-one-pod-per-node
branch
from
September 18, 2024 06:53
4d3d3fb
to
d77db67
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
September 18, 2024 06:53
b94e91f
to
58948ee
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enforce-one-pod-per-node
branch
from
September 18, 2024 08:17
d77db67
to
5825918
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
September 18, 2024 08:18
b92fa47
to
0364b7c
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enforce-one-pod-per-node
branch
from
September 18, 2024 08:27
5825918
to
ee6d69c
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
September 18, 2024 08:27
0364b7c
to
9613a45
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enforce-one-pod-per-node
branch
from
September 18, 2024 08:41
ee6d69c
to
c93fde8
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
September 18, 2024 08:41
9613a45
to
302395c
Compare
gargnitingoogle
changed the title
[testing-on-gke part 6.6] Improvements in run script
[testing-on-gke part 6.7] Improvements in run script
Sep 18, 2024
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enforce-one-pod-per-node
branch
from
September 18, 2024 08:55
c93fde8
to
39ece93
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
September 18, 2024 08:55
302395c
to
5cad921
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enforce-one-pod-per-node
branch
from
September 18, 2024 17:19
39ece93
to
5d75bca
Compare
Option: force_update_gcsfuse_code Default: false This applies when $gcsfuse_src_dir has been passed, or when $src_dir/gcsfuse already exists.
Adds logs for missing sudoless-docker, helpful instruction to install it, and then to re-run the script.
This reverts commit 6fa2ad2. Reverting this because the above commit exposed PII in form of the gcsfuse-internal project IDs and numbers.
The run-gke-tests script should fail if exactly one out of project_id and project_number has been set. It will error out in such as a case.
Add 'Error: ' prefix in all the error logs for easy spotting in log files.
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
October 9, 2024 05:59
3d1dbd7
to
b210bcb
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
from
October 9, 2024 07:43
747107f
to
71db5d8
Compare
kislaykishore
approved these changes
Oct 10, 2024
kislaykishore
approved these changes
Oct 10, 2024
gargnitingoogle
deleted the
garnitin/add-gke-load-testing/improvements-in-run-script
branch
October 10, 2024 09:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvements in run-script:
Error:
as prefix.This is on top of #2497 and is followed up in #2499, #2322, and #2528 .
Link to the issue in case of a bug fix.
NA
Testing details