Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nudge message 3.11 #1797

Merged

Conversation

sameer-google
Copy link
Collaborator

@sameer-google sameer-google commented Sep 18, 2024

  • Users running Python versions other than 3.5 to 3.11 will see a message:
gsutil is supported only for python version 3.5 to 3.11
  • Added a guide for managing Python versions CL for documentation: cl/676817175

Note on Tests Failure:

  • Kokoro tests are failing due to an unrelated test,
    metrics.TestMetricsIntegrationTests.testMetricsPosting
  • A bug has been created to track this issue: b/369285587.

Copy link
Member

@sushantkhanna sushantkhanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fold your commits into one in your feature branch so that Mergr and Rebase is cleaner when this PR is merged.

gsutil.py Outdated Show resolved Hide resolved
@sushantkhanna
Copy link
Member

Please compare the checks with previous PRs. Some have been failing due to an unrelated issue, so as long as that is the case, we should be ok. But if there is any new chnage, then we need to address that.

message edit

combined check

Gsutil Support Check for python versions

detailed message

removed f string

Gsutil Support Check for Python Versions 3.5 to 3.11
Copy link
Member

@sushantkhanna sushantkhanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-run checks failing on test_parallel_rewrite_bucket_flat_wildcard and/or test_cp_preserve_no_owner individually to rule out intermittent errors.
Metrics related failures have been discussed and we are going ahead despite those.

@sameer-google
Copy link
Collaborator Author

Please re-run checks failing on test_parallel_rewrite_bucket_flat_wildcard and/or test_cp_preserve_no_owner individually to rule out intermittent errors. Metrics related failures have been discussed and we are going ahead despite those.

@sushantkhanna sushantkhanna merged commit c8e2709 into GoogleCloudPlatform:master Sep 25, 2024
9 of 36 checks passed
@sameer-google sameer-google deleted the nudge-message-3.11 branch October 11, 2024 05:52
@acecilia
Copy link

acecilia commented Oct 19, 2024

👋 After this PR, using latest python versions 3.12 or 3.13 leads to being unable to run gsutil, and seeing the above error. Until now I have been able to run gsutil with python 3.12 without issues for my usecase.

  • Given that many users may have installed the latest python versions, arent you concerned this validation may be problematic, preventing a big percentage of current gsutil users from running gsutil?

For context: I detected this after updating to Google Cloud CLI version 497. Version 496 works fine, as it does not include this version check

@sameer-google
Copy link
Collaborator Author

sameer-google commented Oct 19, 2024

👋 After this PR, using latest python versions 3.12 or 3.13 leads to being unable to run gsutil, and seeing the above error. Until now I have been able to run gsutil with python 3.12 without issues for my usecase.

  • Given that many users may have installed the latest python versions, arent you concerned this validation may be problematic, preventing a big percentage of current gsutil users from running gsutil?

For context: I detected this after updating to Google Cloud CLI version 497. Version 496 works fine, as it does not include this version check

We are currently working on fully supporting Python 3.12. In the meantime, you can continue using gsutil version 5.30, which is included with Google Cloud CLI version 496. This version does not include the new version check, allowing you to use Python 3.12 without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants