-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google-cloud-sdk: python3 -> python311 #357355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update to at least 500.0.0 instead, which even supports Python 3.13: https://cloud.google.com/sdk/docs/release-notes
Well, I did that the other day: And we still get this error it seems. |
Seems gsutil still don't support python 3.12: |
I'm wondering if this check is actually faulty GoogleCloudPlatform/gsutil#1808 - Maybe we can patch out the check in gustily.py instead of reverting the sdk to an older python? |
Seems we should be able to patch it out: In the meantime while waiting for their update to fully support 3.12. It has not been less supported than now before the version check and I guess 3.12 has been used for a while... |
nice find(s). i'm not versed well enough with python to tell if it should run fine on python 3.12 or not. feel free to close this if/when you patch the version check out 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to do this then revert when upstream resolves python312 support for gsutil.
Could reproduce the issue and confirm this workaround on a workplace private repository.
pin the python version to 3.11 as the latest google-cloud-sdk bump broke gsutil with:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.