Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added maxUsableWorkstations to workstation Config #11908

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Oct 3, 2024

Change-Id: I81e020c0af508ab6376fdd71226de265d65c58ad

fixes: hashicorp/terraform-provider-google#19623

Release Note Template for Downstream PRs (will be copied)

workstations: added `maxUsableWorkstations`  field to `WorkstationConfiguration` resource.

Change-Id: I81e020c0af508ab6376fdd71226de265d65c58ad
@github-actions github-actions bot requested a review from BBBmau October 3, 2024 17:19
Copy link

github-actions bot commented Oct 3, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 4 files changed, 63 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_workstations_workstation_config (42 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_workstations_workstation_config" "primary" {
  max_usable_workstations = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 35
Passed tests: 30
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • workstations

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfigIamBindingGenerated
  • TestAccWorkstationsWorkstationConfigIamMemberGenerated
  • TestAccWorkstationsWorkstationConfigIamPolicyGenerated
  • TestAccWorkstationsWorkstationConfig_update
  • TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfigIamBindingGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfigIamMemberGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_update[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Change-Id: Icd2a1127e527ebb28463ee1c20e29ca4c6009a55
@github-actions github-actions bot requested a review from BBBmau October 3, 2024 17:37
Change-Id: Ib8c88ab370422bab4e87a5699e699e9ed5c47a9b
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 5 files changed, 65 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_workstations_workstation_config (41 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_workstations_workstation_config" "primary" {
  max_usable_workstations = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 35
Passed tests: 30
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • workstations

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfigIamBindingGenerated
  • TestAccWorkstationsWorkstationConfigIamMemberGenerated
  • TestAccWorkstationsWorkstationConfigIamPolicyGenerated
  • TestAccWorkstationsWorkstationConfig_update
  • TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfigIamBindingGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfigIamMemberGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_update[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 5 files changed, 66 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_workstations_workstation_config (41 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_workstations_workstation_config" "primary" {
  max_usable_workstations = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 35
Passed tests: 30
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • workstations

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfigIamBindingGenerated
  • TestAccWorkstationsWorkstationConfigIamMemberGenerated
  • TestAccWorkstationsWorkstationConfigIamPolicyGenerated
  • TestAccWorkstationsWorkstationConfig_update
  • TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfigIamBindingGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfigIamMemberGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_update[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Change-Id: If5bbedcc4aa9d730cc8d18be8e7b8d6980303ade
Change-Id: Idd012887b28bc9a547d165765e5a1ad0388e575d
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 5 files changed, 66 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 5 files changed, 66 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 35
Passed tests: 30
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • workstations

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfigIamBindingGenerated
  • TestAccWorkstationsWorkstationConfigIamMemberGenerated
  • TestAccWorkstationsWorkstationConfigIamPolicyGenerated
  • TestAccWorkstationsWorkstationConfig_update
  • TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 5 files changed, 66 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 35
Passed tests: 30
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • workstations

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfigIamBindingGenerated
  • TestAccWorkstationsWorkstationConfigIamMemberGenerated
  • TestAccWorkstationsWorkstationConfigIamPolicyGenerated
  • TestAccWorkstationsWorkstationConfig_update
  • TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 35
Passed tests: 30
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • workstations

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfigIamBindingGenerated
  • TestAccWorkstationsWorkstationConfigIamMemberGenerated
  • TestAccWorkstationsWorkstationConfigIamPolicyGenerated
  • TestAccWorkstationsWorkstationConfig_update
  • TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccWorkstationsWorkstationConfigIamBindingGenerated[Debug log]
TestAccWorkstationsWorkstationConfigIamMemberGenerated[Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Change-Id: I6b1f5d6a545a8b902260f40aff455fe48d6d37f1
@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccWorkstationsWorkstationConfigIamBindingGenerated[Debug log]
TestAccWorkstationsWorkstationConfigIamMemberGenerated[Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccWorkstationsWorkstationConfigIamBindingGenerated[Debug log]
TestAccWorkstationsWorkstationConfigIamMemberGenerated[Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 5 files changed, 66 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 35
Passed tests: 34
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfig_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_update[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@tejal29
Copy link
Contributor Author

tejal29 commented Oct 4, 2024

@BBBmau Can we merge this in before next release?

Change-Id: Ie280c56d7126d14b71346f0a20bc8e279ebc237c
@github-actions github-actions bot requested a review from SarahFrench October 8, 2024 17:25
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 5 files changed, 66 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 35
Passed tests: 35
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • workstations

🟢 All tests passed!

View the build log

Copy link

github-actions bot commented Oct 11, 2024

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@SarahFrench SarahFrench removed their request for review October 11, 2024 09:42
@github-actions github-actions bot requested a review from SarahFrench October 15, 2024 20:37
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 5 files changed, 66 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 37
Passed tests: 36
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfig_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_update[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@BBBmau BBBmau merged commit a8e718b into GoogleCloudPlatform:main Oct 15, 2024
12 of 13 checks passed
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
…m#11908)

Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
varshatumburu pushed a commit to varshatumburu/magic-modules that referenced this pull request Oct 19, 2024
…m#11908)

Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
BBBmau added a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
…m#11908)

Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
BBBmau added a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
…m#11908)

Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
BBBmau added a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
…m#11908)

Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
…m#11908)

Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
…m#11908)

Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add maxUsableWorkstations to google_workstations_workstation_config resource
4 participants