-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added maxUsableWorkstations to workstation Config #11908
Conversation
Change-Id: I81e020c0af508ab6376fdd71226de265d65c58ad
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_workstations_workstation_config" "primary" {
max_usable_workstations = # value needed
}
|
Tests analyticsTotal tests: 35 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Change-Id: Icd2a1127e527ebb28463ee1c20e29ca4c6009a55
Change-Id: Ib8c88ab370422bab4e87a5699e699e9ed5c47a9b
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_workstations_workstation_config" "primary" {
max_usable_workstations = # value needed
}
|
Tests analyticsTotal tests: 35 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_workstations_workstation_config" "primary" {
max_usable_workstations = # value needed
}
|
Tests analyticsTotal tests: 35 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Change-Id: If5bbedcc4aa9d730cc8d18be8e7b8d6980303ade
Change-Id: Idd012887b28bc9a547d165765e5a1ad0388e575d
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 35 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 35 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
1 similar comment
Tests analyticsTotal tests: 35 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Change-Id: I6b1f5d6a545a8b902260f40aff455fe48d6d37f1
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 35 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
@BBBmau Can we merge this in before next release? |
Change-Id: Ie280c56d7126d14b71346f0a20bc8e279ebc237c
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 35 Click here to see the affected service packages
🟢 All tests passed! View the build log |
@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 37 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
…m#11908) Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
…m#11908) Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
…m#11908) Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
…m#11908) Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
…m#11908) Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
…m#11908) Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
…m#11908) Co-authored-by: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
Change-Id: I81e020c0af508ab6376fdd71226de265d65c58ad
fixes: hashicorp/terraform-provider-google#19623
Release Note Template for Downstream PRs (will be copied)