Ip address selection policy #11957
Ip address selection policy #11957
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
Resource: resource "google_compute_region_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
|
Tests analyticsTotal tests: 1026 Click here to see the affected service packages
Action takenFound 176 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
Resource: resource "google_compute_region_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
Resource: resource "google_compute_region_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
|
Tests analyticsTotal tests: 1028 Click here to see the affected service packages
Action takenFound 111 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
Resource: resource "google_compute_region_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
|
1 similar comment
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
Resource: resource "google_compute_region_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
|
Tests analyticsTotal tests: 1028 Click here to see the affected service packages
Action takenFound 112 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
Resource: resource "google_compute_region_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
|
1 similar comment
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
Resource: resource "google_compute_region_backend_service" "primary" {
ip_address_selection_policy = # value needed
}
|
Tests analyticsTotal tests: 1028 Click here to see the affected service packages
Action takenFound 111 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Tests analyticsTotal tests: 1028 Click here to see the affected service packages
Action takenFound 67 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 1028 Click here to see the affected service packages
Action takenFound 67 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
1 similar comment
Tests analyticsTotal tests: 1028 Click here to see the affected service packages
Action takenFound 67 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Tests analyticsTotal tests: 1032 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
1 similar comment
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1032 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Tests analyticsTotal tests: 1032 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
| resource "google_compute_region_backend_service" "{{$.PrimaryResourceId}}" { | ||
| name = "{{index $.Vars "region_backend_service_name"}}" | ||
| region = "us-central1" | ||
| health_checks = [google_compute_region_health_check.default.id] |
There was a problem hiding this comment.
Looks like this should be google_compute_region_health_check. health_check.id, then hopefully tests will pass
There was a problem hiding this comment.
Thanks, should be fixed. I figured out how to run manually and it's passing in my repo now also.
$ make testacc TEST=./google/services/compute TESTARGS='-run=TestAccComputeRegionBackendService_regionBackendServiceIpAddressSelectionPolicyExample'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/compute -v -run=TestAccComputeRegionBackendService_regionBackendServiceIpAddressSelectionPolicyExample -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN TestAccComputeRegionBackendService_regionBackendServiceIpAddressSelectionPolicyExample
=== PAUSE TestAccComputeRegionBackendService_regionBackendServiceIpAddressSelectionPolicyExample
=== CONT TestAccComputeRegionBackendService_regionBackendServiceIpAddressSelectionPolicyExample
--- PASS: TestAccComputeRegionBackendService_regionBackendServiceIpAddressSelectionPolicyExample (40.34s)
PASS
ok github.com/hashicorp/terraform-provider-google/google/services/compute 40.804s
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1032 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Add ipAddressSeelectionPolicy field to BackendService and RegionBackendService.
Release Note Template for Downstream PRs (will be copied)