-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ip address selection policy #11957
Merged
roaks3
merged 17 commits into
GoogleCloudPlatform:main
from
jlporter:ip-address-selection-policy
Oct 15, 2024
Merged
Ip address selection policy #11957
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c204359
Add ipAddressSelectionPolicy to BackendService.yaml
jlporter 81236e8
add ipAddressSelectionPolicy to RegionBackendService.yaml
jlporter 12b8bbb
Create backend_service_ip_address_selection_policy.tf.tmpl
jlporter 11a20c5
Create region_backend_service_ip_address_selection_policy.tf.tmpl
jlporter a2709d8
Use google-beta provider in backend_service_ip_address_selection_poli…
jlporter 0942b4f
Use EXTERNAL_MANAGED LB scheme in backend_service_ip_address_selectio…
jlporter 28182ae
Remove default_value from ipAddressSelectionPolicy in BackendService.…
jlporter 93cd418
Remove default_value from ipAddressSelectionPolicy in RegionBackendSe…
jlporter 3a15b83
Remove min_version from ipAddressSelectionPolicy in BackendService.ya…
jlporter 85483d8
Remove min_version for IpAddressSelectionPolicy in RegionBackendServi…
jlporter 0152299
Remove provider=google_beta, this should be available in v1 now.
jlporter 4ec4cd9
Remove provider=google_beta, this should be available in v1 now.
jlporter 6d86306
Add example to BackendService.yaml
jlporter 42f9f57
Add example to RegionBackendService.yaml
jlporter ec502ef
Fix health check in region_backend_service_ip_address_selection_polic…
jlporter ba18542
Fix health check in ip_address_selection example in RegionBackendServ…
jlporter 67c3cbb
Fix resource name in region_backend_service_ip_address_selection_poli…
jlporter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
mmv1/templates/terraform/examples/backend_service_ip_address_selection_policy.tf.tmpl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
resource "google_compute_backend_service" "{{$.PrimaryResourceId}}" { | ||
name = "{{index $.Vars "backend_service_name"}}" | ||
load_balancing_scheme = "EXTERNAL_MANAGED" | ||
ip_address_selection_policy = "IPV6_ONLY" | ||
} |
18 changes: 18 additions & 0 deletions
18
mmv1/templates/terraform/examples/region_backend_service_ip_address_selection_policy.tf.tmpl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
resource "google_compute_region_backend_service" "{{$.PrimaryResourceId}}" { | ||
name = "{{index $.Vars "region_backend_service_name"}}" | ||
region = "us-central1" | ||
health_checks = [google_compute_region_health_check.health_check.id] | ||
|
||
load_balancing_scheme = "EXTERNAL_MANAGED" | ||
protocol = "HTTP" | ||
ip_address_selection_policy = "IPV6_ONLY" | ||
} | ||
|
||
resource "google_compute_region_health_check" "health_check" { | ||
name = "{{index $.Vars "health_check_name"}}" | ||
region = "us-central1" | ||
|
||
tcp_health_check { | ||
port = 80 | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't seen these examples being picked up anywhere (to be used in the docs and/or tests). Did you perhaps forget to add
examples
blocks in the yaml files?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, indeed, they should be added now.