-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark google_sql_database_instance.settings.data_cache_config
Computed
#12096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileykarson
requested review from
a team and
trodge
and removed request for
a team
October 22, 2024 21:17
5 tasks
Tests analyticsTotal tests: 100 Click here to see the affected service packages
🟢 All tests passed! View the build log |
trodge
approved these changes
Oct 22, 2024
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Nov 5, 2024
5 tasks
Spheny1
pushed a commit
to Spheny1/magic-modules
that referenced
this pull request
Nov 13, 2024
akshat-jindal-nit
pushed a commit
to akshat-jindal-nit/magic-modules
that referenced
this pull request
Nov 18, 2024
This was referenced Nov 19, 2024
amanMahendroo
pushed a commit
to amanMahendroo/magic-modules
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Described in https://cloud.google.com/sql/docs/mysql/data-cache and https://cloud.google.com/sql/docs/mysql/editions-intro, it's regular for the server to modify this value. I'm not entirely sure it's configurable, honestly, but not addressing that question here.
Fixes TestAccSqlDatabaseInstance_Edition, TestAccSqlDatabaseInstance_Edition_Downgrade in theory
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.