Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark google_sql_database_instance.settings.data_cache_config Computed #12096

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Oct 22, 2024

Described in https://cloud.google.com/sql/docs/mysql/data-cache and https://cloud.google.com/sql/docs/mysql/editions-intro, it's regular for the server to modify this value. I'm not entirely sure it's configurable, honestly, but not addressing that question here.

Fixes TestAccSqlDatabaseInstance_Edition, TestAccSqlDatabaseInstance_Edition_Downgrade in theory

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

sql: made `google_sql_database_instance.0.settings.0.data_cache_config` accept server-side changes when unset. When unset, no diffs will be created when instances change in `edition` and the feature is enabled or disabled as a result.

@rileykarson rileykarson requested review from a team and trodge and removed request for a team October 22, 2024 21:17
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 100
Passed tests: 85
Skipped tests: 15
Affected tests: 0

Click here to see the affected service packages
  • sql

🟢 All tests passed!

View the build log

@rileykarson rileykarson merged commit 86bf353 into main Oct 22, 2024
14 checks passed
@rileykarson rileykarson deleted the rileykarson-patch-7 branch October 22, 2024 21:46
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
Spheny1 pushed a commit to Spheny1/magic-modules that referenced this pull request Nov 13, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants