Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark google_sql_database_instance.settings.data_cache_config Computed #19972

Conversation

modular-magician
Copy link
Collaborator

Described in https://cloud.google.com/sql/docs/mysql/data-cache and https://cloud.google.com/sql/docs/mysql/editions-intro, it's regular for the server to modify this value. I'm not entirely sure it's configurable, honestly, but not addressing that question here.

Fixes TestAccSqlDatabaseInstance_Edition, TestAccSqlDatabaseInstance_Edition_Downgrade in theory

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

sql: made `google_sql_database_instance.0.settings.0.data_cache_config` accept server-side changes when unset. When unset, no diffs will be created when instances change in `edition` and the feature is enabled or disabled as a result.

Derived from GoogleCloudPlatform/magic-modules#12096

…ed (hashicorp#12096)

[upstream:86bf3535fbc1bf4551e4729a5728347f7e401fe7]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 1f94e31 into hashicorp:main Oct 22, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-86bf3535fbc1bf4551e4729a5728347f7e401fe7 branch November 17, 2024 03:35
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant