Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute: update tdx tests to use standard images #12149

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Oct 26, 2024

It seems like the fix in #12062 may not have fixed the images relying on Ubuntu images in the tdx-guest-images project.

I'm not sure if this is the right fix, but running one of the affected tests seemed to work for me (and the UI showed confidential mode enabled), so maybe this support is now available in the mainstream image?

Added a comment with more context here:
hashicorp/terraform-provider-google#19885 (comment)
but seems like this may just be natively supported in the stock Ubuntu images now.

Part of hashicorp/terraform-provider-google#19885

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


It seems like the fix in GoogleCloudPlatform#12062 may not have fixed the images relying on
Ubuntu images in the `tdx-guest-images` project.

Part of hashicorp/terraform-provider-google#19885
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from shuyama1 October 26, 2024 04:58
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Oct 26, 2024
@wyardley wyardley changed the title test: update tdx tests to use standard images compute: update tdx tests to use standard images Oct 26, 2024
@modular-magician modular-magician added service/compute-instances and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Oct 29, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 5 files changed, 5 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1044
Passed tests: 966
Skipped tests: 73
Affected tests: 5

Click here to see the affected service packages
  • compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceConfidentialInstanceConfigMain
  • TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
  • TestAccComputeInstanceFromTemplate_confidentialInstanceConfigMain
  • TestAccComputeInstanceTemplate_ConfidentialInstanceConfigMain
  • TestAccComputeRegionInstanceTemplate_ConfidentialInstanceConfigMain

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceConfidentialInstanceConfigMain [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Debug log]
TestAccComputeInstanceFromTemplate_confidentialInstanceConfigMain [Debug log]
TestAccComputeInstanceTemplate_ConfidentialInstanceConfigMain [Debug log]
TestAccComputeRegionInstanceTemplate_ConfidentialInstanceConfigMain [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants