-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compute: update tdx tests to use standard images #12149
Conversation
It seems like the fix in GoogleCloudPlatform#12062 may not have fixed the images relying on Ubuntu images in the `tdx-guest-images` project. Part of hashicorp/terraform-provider-google#19885
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1044 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
It seems like the fix in #12062 may not have fixed the images relying on Ubuntu images in the
tdx-guest-images
project.I'm not sure if this is the right fix, but running one of the affected tests seemed to work for me (and the UI showed confidential mode enabled), so maybe this support is now available in the mainstream image?
Added a comment with more context here:
hashicorp/terraform-provider-google#19885 (comment)
but seems like this may just be natively supported in the stock Ubuntu images now.
Part of hashicorp/terraform-provider-google#19885
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.