compute: added support for advanced_machine_features.turbo_mode

[wyardley]

• Added support for advanced_machine_features.turbo_mode in google_compute_instance, google_compute_instance_template, and google_compute_region_instance_template
• Adjusted tests to use c4 instance types for advanced_machine_features tests
• Minor docs and formatting fixes

Fixes hashicorp/terraform-provider-google#20023

I'm guessing this may be missing something

I looked at adding it in google_container_cluster as well, but seems like it's not implemented yet in regular or beta container API.

Side note: EnableUefiNetworking and PerformanceMonitoringUnit also seem to be available here but not implemented in the provider yet.

Should I add anything in tgc as well (like #10848)?

Release Note Template for Downstream PRs (will be copied)

compute: added support for `advanced_machine_features.turbo_mode` to `google_compute_instance`, `google_compute_instance_template`, and `google_compute_region_instance_template`

[wyardley]

Note: these tests pass for me locally, but only if I explicitly set subnetwork = default in network_interface; given the number of other tests that are using the default network (and no explicitly set subnetwork) vs. a bootstrapped created network, I assume it'll be Ok.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[roaks3]

LGTM, just need to verify tests

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 64 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 10 files changed, 64 insertions(+), 27 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 2 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  advanced_machine_features {
    enable_nested_virtualization = # value needed
    threads_per_core             = # value needed
    turbo_mode                   = # value needed
    visible_core_count           = # value needed
  }
}

Resource: google_compute_instance_from_template (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  advanced_machine_features {
    enable_nested_virtualization = # value needed
    threads_per_core             = # value needed
    turbo_mode                   = # value needed
    visible_core_count           = # value needed
  }
}

[wyardley]

btw, if the TDX / confidential image tests for compute fail, that may be a known / pre-existing issue (hashicorp/terraform-provider-google#19885). I have #12149 up as a possible fix for those.

[modular-magician]

Tests analytics

Total tests: 1044
Passed tests: 966
Skipped tests: 73
Affected tests: 5

Click here to see the affected service packages

• compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceConfidentialInstanceConfigMain
• TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
• TestAccComputeInstanceTemplate_AdvancedMachineFeatures
• TestAccComputeInstance_advancedMachineFeatures
• TestAccComputeRegionInstanceTemplate_AdvancedMachineFeatures

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceTemplate_AdvancedMachineFeatures [Debug log]
TestAccComputeInstance_advancedMachineFeatures [Debug log]
TestAccComputeRegionInstanceTemplate_AdvancedMachineFeatures [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceConfidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[wyardley]

@roaks3 that test PR is merged if you want to re-run the tests now.

w/r/t the missing test warning, I think the existing test coverage for templates probably should cover most use cases, but let me know if you want to see something else tested.

[roaks3]

Yea, I think the tests you have are sufficient, and the test failures look unrelated.