Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute: added support for advanced_machine_features.turbo_mode #8551

Conversation

modular-magician
Copy link
Collaborator

  • Added support for advanced_machine_features.turbo_mode in google_compute_instance, google_compute_instance_template, and google_compute_region_instance_template
  • Adjusted tests to use c4 instance types for advanced_machine_features tests
  • Minor docs and formatting fixes

Fixes hashicorp/terraform-provider-google#20023

I'm guessing this may be missing something

I looked at adding it in google_container_cluster as well, but seems like it's not implemented yet in regular or beta container API.

Side note: EnableUefiNetworking and PerformanceMonitoringUnit also seem to be available here but not implemented in the provider yet.

Should I add anything in tgc as well (like #10848)?

Release Note Template for Downstream PRs (will be copied)

compute: added support for `advanced_machine_features.turbo_mode` to `google_compute_instance`, `google_compute_instance_template`, and `google_compute_region_instance_template`

Derived from GoogleCloudPlatform/magic-modules#12148

…2148)

[upstream:81d523574d46ee655583b3e96fe38399cf8d0d91]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 227afcc into hashicorp:main Oct 29, 2024
2 checks passed
@modular-magician modular-magician deleted the downstream-pr-81d523574d46ee655583b3e96fe38399cf8d0d91 branch November 16, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

advancedMachineFeatures.turboMode missing
1 participant