-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove use of pull_request_target (part 1) #3747
Conversation
|
||
When a Pull Request is opened, reopened, or has new commits pushed the tests will be run. | ||
|
||
If the tests for a sample change do not run, they can be triggered by adding the `actions:force-run` label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only triggers a subset of tests right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is for the sample tests, as distinguished from all validations/checks that are run.
Added a comment with a suggestion to clarify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor doc updates/subtle log message change, but I'm cool with this as is as an incremental improvement towards better and getting us to testing this and validating this approach.
It appears there are multiple problems with the ai-platform-snippets, but fixing them is out of scope here. Going to swap them out for another test suite to make sure we have an end-to-end example of this approach working. |
Added the |
Description
This change is the start on removing
pull_request_target
from sample testing workflows.pull_request
trigger, and remove thepull_request_target
.Workshop the pattern and guidance here, then migrate remaining workflows to this trigger configuration in follow-up.
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.