Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update s-z workflows to use labeled on pull_request trigger #3752

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

grayside
Copy link
Collaborator

Description

Scoped to Samples workflows with file names starting with s-z.

Implementation of #3747, sibling of #3748.

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Jul 19, 2024
@@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: workflows
name: cloudworkflows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, good catch to make this more clear.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was triggering GHA lint errors in vscode.

@grayside
Copy link
Collaborator Author

  • scheduler: initial failure with timeout. manual retry fixed
  • talent: test failure from sample bug, possibly a race condition? manual retry fixed
  • speech: test failure. retry failed
  • translate: failed. retry failed
  • videointelligence: failed. retry failed
  • vision: failed, retry failed
  • vision-productSearch: failed, retry failed

@grayside
Copy link
Collaborator Author

These test failures are out of scope. Assembled notes to file follow-up bugs.

@grayside grayside marked this pull request as ready for review July 22, 2024 17:22
@grayside grayside requested review from a team as code owners July 22, 2024 17:22
@grayside grayside enabled auto-merge (squash) July 22, 2024 18:46
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! acknowledging that the test failures will be resolved later.

@grayside grayside merged commit 997bf90 into main Jul 22, 2024
25 of 45 checks passed
@grayside grayside deleted the prt-sz-tests branch July 22, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions:force-run api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants