-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make client auth extension public and implement component.Component #814
Make client auth extension public and implement component.Component #814
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
==========================================
+ Coverage 59.79% 60.07% +0.28%
==========================================
Files 56 56
Lines 5743 5896 +153
==========================================
+ Hits 3434 3542 +108
- Misses 2159 2202 +43
- Partials 150 152 +2 ☔ View full report in Codecov by Sentry. |
Given how small this library is, should the entire thing just live upstream? |
I'm thinking it's best to do it the same way we do with our exporters, where the code lives downstream so we have more control over testing and updates. We can always follow up with moving the rest of the code upstream if we want. |
c831eea
to
09a443b
Compare
@dashpole updated this like we talked about offline, ready for review now |
Working on contributing this upstream (open-telemetry/opentelemetry-collector-contrib#31518), we will need to export some of the functions like CreateExtension and CreateDefaultConfig. This also implements the
component.Component
interface so the extension can be created without callinggoogle.FindDefaultCredentials()
, which can result in an immediate error if the credentials are not found. This enables lifecycle tests upstream.