[extension/googleclientauth] Add new component boilerplate scaffolding #31518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dashpole
reviewed
Mar 1, 2024
crobert-1
reviewed
Mar 1, 2024
dashpole
added
the
Vendor-Specific Component
damemi
force-pushed
the
gcp-auth-ext
branch
5 times, most recently
from
c6ff818 to
750bd58
Compare
|
I tried skipping the lifecycle/shutdown tests for now in metadata.yaml and ran |
damemi
force-pushed
the
gcp-auth-ext
branch
2 times, most recently
from
4f4e531 to
179e78f
Compare
|
I'm trying to run |
|
I would just manually update the file with the diff |
crobert-1
reviewed
Mar 8, 2024
damemi
force-pushed
the
gcp-auth-ext
branch
6 times, most recently
from
3e6f71e to
dee2c99
Compare
crobert-1
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Just some minor formatting nits. 👍 Also, I realized it might be a good time to add goleak checks to your component now, to help ensure it doesn't leak goroutines. You can simply add a package_test.go file to your component's directory, contents could be copied from here.
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
dashpole
approved these changes
Mar 13, 2024
crobert-1
approved these changes
Mar 13, 2024
| exporters: [otlp/withauth] | ||
| ``` | ||
|
|
||
| The following optional config fields are available: |
There was a problem hiding this comment.
Nit: It might make sense to have the options defined before the example. Not a big deal either way though. 👍
andrzej-stencel
approved these changes
Mar 15, 2024
andrzej-stencel
added
the
ready to merge
djaglowski
pushed a commit
that referenced
this pull request
Apr 15, 2024
…32029) **Description:** Follow up to boilerplate PR #31518 This adds the functions calls to actually implement the extension using our downstream libraries. It also enables the shutdown tests for this extension (lifecycle tests do not seem possible for us currently) **Link to tracking Issue:** n/a **Testing:** downstream unit and integration tests, shutdown tests here **Documentation:** Here and downstream READMEs
djaglowski
pushed a commit
that referenced
this pull request
Apr 18, 2024
…2442) **Description:** <Describe what has changed.> Follow up to #32029 and #31518 This marks the `googleclientauthextension` as `alpha` following the [contributing doc](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components) and [alpha stability guidelines](https://github.com/open-telemetry/opentelemetry-collector#alpha). It also adds it to `otelcontribcol` Note this also updates CONTRIBUTING.md to explain how to add the alpha component to otelcontribcol. **Link to tracking Issue:** N/A **Testing:** Downstream unit and integration tests **Documentation:** No changes except stability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds the basic component boilerplate following the recommendations for PR1 in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components
Link to tracking Issue: #31412
Testing: Ran various
make ...commands as listed in docs. Ignored generated files and failures from unrelated components.Documentation: New readme and metadata (to be filled in, see tracking issue)