Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/googleclientauth] Mark GCP client auth extension alpha #32442

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Apr 16, 2024

Description:
Follow up to #32029 and #31518
This marks the googleclientauthextension as alpha following the contributing doc and alpha stability guidelines. It also adds it to otelcontribcol

Note this also updates CONTRIBUTING.md to explain how to add the alpha component to otelcontribcol.

Link to tracking Issue: N/A

Testing: Downstream unit and integration tests

Documentation: No changes except stability

@damemi damemi requested a review from a team April 16, 2024 14:01
@github-actions github-actions bot requested review from aabmass, psx95 and punya April 16, 2024 14:01
@damemi damemi changed the title Gcp auth extension alpha [extension/googleclientauth] Mark GCP client auth extension alpha Apr 16, 2024
@damemi
Copy link
Contributor Author

damemi commented Apr 16, 2024

I must have done something wrong, because I'm stuck in a loop getting CI to pass.

I need to run make genotelcontribcol, which removes the replace in go.mod for the extension. Then I run make crosslink which removes go.mod references to our downstream code for the extension. Then, if I run go mod tidy in cmd/otelcontribcol, it gets me back to CI saying I need to run make genotelcontribcol again.

Is there a certain order I should run these?

@damemi damemi force-pushed the gcp-auth-extension-alpha branch 3 times, most recently from 5fd7b76 to 9bb096f Compare April 17, 2024 15:24
@damemi
Copy link
Contributor Author

damemi commented Apr 17, 2024

Think I got it, I was missing the replace in builder-config.yaml, weird that crosslink will add that automatically to go.mod but you still need to add it manually to the builder config

@damemi damemi force-pushed the gcp-auth-extension-alpha branch from 9bb096f to 16822ba Compare April 17, 2024 16:04
@damemi
Copy link
Contributor Author

damemi commented Apr 17, 2024

@dashpole think I got it all sorted out, this is ready to merge

@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Apr 17, 2024
@damemi
Copy link
Contributor Author

damemi commented Apr 18, 2024

@djaglowski ping, this is ready for review/merge

@djaglowski djaglowski merged commit 295ca65 into open-telemetry:main Apr 18, 2024
160 of 161 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/otelcontribcol otelcontribcol command extension/googleclientauth ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants