Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App engine upversion #2437

Merged
merged 3 commits into from
Oct 8, 2019
Merged

App engine upversion #2437

merged 3 commits into from
Oct 8, 2019

Conversation

gguuss
Copy link
Contributor

@gguuss gguuss commented Oct 4, 2019

Updates app engine versions in split PR.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2019
@gguuss gguuss requested a review from dpebot October 4, 2019 19:52
@gguuss gguuss requested a review from crwilcox October 4, 2019 23:44
@gguuss
Copy link
Contributor Author

gguuss commented Oct 4, 2019

Tests are green, take a look soon as these will conflict with virtually any PR and take a long time to run.

@gguuss gguuss removed the request for review from dpebot October 8, 2019 16:31
@crwilcox crwilcox merged commit 2b2cef9 into master Oct 8, 2019
bradmiro added a commit that referenced this pull request Oct 8, 2019
* Adds updates for samples profiler ... vision (#2439)

* cloud-sql: add Cloud Run support to sqlalchemy sample (#2449)

* Adds split updates for Firebase ... opencensus (#2438)

* App engine upversion (#2437)

* App engine upversion

* Python 2 compatible pytest

* Dataflow client library (#2450)

* Updated requirements

* Update service naming convention

* Prefer client libraries over shell commands

* Update README format
@gguuss gguuss deleted the cpebot-fixstyle-appengine branch October 9, 2019 19:51
@@ -1,2 +1,2 @@
Django==2.1.11
Django==2.2.5
Copy link

@Chetchaiyan Chetchaiyan Oct 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found problem when upgrade Django from 2.1.11 to 2.2.5 as shown in this update.

The error state that
django.core.exceptions.ImproperlyConfigured: mysqlclient 1.3.13 or newer is required; you have 0.9.3.
Which shown the problem coming from PyMySQL 0.9.3

Can you give me advise on fixing or avoiding this error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chetchaiyan I think you just need to update your mysqlclient version in your project requirements to be mysqlclient==1.4.4 or run pip install --upgrade mysqlclient. You're confusing this library with PyMySQL, which is in fact version 0.9.3.

Feel free to follow up offline with me, email is github<at>gusclass<dot>com

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chetchaiyan I am having the same issue.

@gguuss I tried both of your suggestions:

  • Adding mysqlclient==1.4.4 to the requirements.txt then running pip install -r requirements.txt
  • Or running pip install --upgrade mysqlclient

For both of your suggestions I got these errors:

  • ERROR: Command errored out with exit status 1
  • ...
  • MySQLdb/_mysql.c(29): fatal error C1083: Cannot open include file: 'mysql.h': No such file or directory
  • ...
  • ERROR: Failed building wheel for mysqlclient

However, when I simply change back Django==2.1.11 everything runs exactly as it is described in this Getting Started guide that I am following. Therefore, I was able to successfully finish the guide and achieve my learning objective but I'm concerned another beginner behind me may not get to completion and get frustrated with this same error. It seems to me that something else needs to be addressed in the appengine/standard_python37/django/ example when upgrading to Django to 2.2.5 but I'm too novice at Python and Django to know / understand what else needs to be changed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skeleton of the project requirements.txt makes the assumption that we are going to be using PyMySQL, which is incompatible with Django 2.2.5. I suggest either changing the requirement to use mysqlclient instead or wait for a PyMySQL version bump.

arithmetic1728 pushed a commit to googleapis/python-tasks that referenced this pull request Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants