Dataflow client library #2450
Dataflow client library #2450
Conversation
googlebot
added
the
cla: yes
davidcavazos
added
dependencies
davidcavazos
force-pushed
the
dataflow-cancel-client-library
branch
from
b02c4e1 to
aa076f1
Compare
davidcavazos
removed
the
kokoro:force-run
| jobId=job_id, | ||
| body={'requestedState': 'JOB_STATE_CANCELLED'} | ||
| ) | ||
| request.execute() |
There was a problem hiding this comment.
In the subprocess approach, you check for success, can you check here or is this "fire and forget"? Probably fine either way as it's a small job.
There was a problem hiding this comment.
Yes, after closer inspection that shouldn't actually be the case. If launching the template fails it will raise an exception which will cause the test to fail.
The job can only be cancelled after it changes status from not started into ready or something like that which takes a couple seconds (usually). That's why we're sleeping for 5 seconds. However, if for some reason it takes longer and it cannot be cancelled, the job will still run for 5-8 minutes which is not a big deal, but that shouldn't cause the test to fail.
So we're cancelling as a best effort to try to minimize resources used, so I think we're fine in not checking the output of the cancel.
davidcavazos
force-pushed
the
dataflow-cancel-client-library
branch
from
aa076f1 to
9ddcdc9
Compare
* Adds updates for samples profiler ... vision (#2439) * cloud-sql: add Cloud Run support to sqlalchemy sample (#2449) * Adds split updates for Firebase ... opencensus (#2438) * App engine upversion (#2437) * App engine upversion * Python 2 compatible pytest * Dataflow client library (#2450) * Updated requirements * Update service naming convention * Prefer client libraries over shell commands * Update README format
subprocess