Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(codegen): add test to verify getting the intended bean with qualifier name. #1418

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Jan 3, 2023

This is a followup on #1355, the additional test verifies in case of multiple bean of type TransportChannelProvider the one with correct qualifier name is used.
related fix in generator: googleapis/sdk-platform-java#1207

@zhumin8 zhumin8 added the codegen label Jan 3, 2023
@zhumin8 zhumin8 marked this pull request as ready for review January 3, 2023 22:52
@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zhumin8 zhumin8 merged commit c2b125e into main Jan 11, 2023
@zhumin8 zhumin8 deleted the fix-unit-test branch January 11, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants