Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cicd(codegen): Fix sonar ignore #1421

Closed
wants to merge 3 commits into from
Closed

cicd(codegen): Fix sonar ignore #1421

wants to merge 3 commits into from

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Jan 4, 2023

Goal: to skip sonar checks on spring-cloud-previews modules. Do not affect other check on other modules.
Previous attempt: #1416 - added to ignore path;
Issue: sonar ignores any changes in spring-cloud-previews/ folder, but sonar check is set as required to merge into main branch. So PRs with changes in spring-cloud-previews modules (manual unit test changes, generated code) won’t be able to merge. (e.g.#1418)
Solution:

Concern: If new changes existing modules occurs, needs to change both modules in default profile and codecov profile.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@meltsufin
Copy link
Member

What kind of failures does Sonar report on the auto-generated starters?

@zhumin8
Copy link
Contributor Author

zhumin8 commented Jan 4, 2023

@meltsufin I expect Sonar will fail on test coverage since we only have unit test for one module.

@meltsufin
Copy link
Member

Maybe we can just exclude it from code coverage calculation then. I think jacoco has setting for that.

@zhumin8 zhumin8 added the codegen label Jan 4, 2023
@zhumin8
Copy link
Contributor Author

zhumin8 commented Jan 4, 2023

Ah, that sounds like a better idea. Let me look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants