[DO NOT MERGE] Source of breakdown of changes in #1407 #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
diegomarquezp
added a commit
that referenced
this pull request
Jan 7, 2023
The source of changes was moved to #1422 for which several PRs were made and are now either closed or merged (#1430, #1428, #1427, #1426, #1425 , #1424). #1423 has not been merged as gapic-generator-java/1212 will invalidate this fix The found (and fixed) errors were: * the call to `xmllint` did not handle an empty `<modules>` list, causing the module addition function to fail in `generate-one` * missing `OPTARG` key `-x`, for commitish in `generate-one`
diegomarquezp
added a commit
that referenced
this pull request
Jan 13, 2023
* fix: after merging breakdown of #1407 The source of changes was moved to #1422 for which several PRs were made and are now either closed or merged (#1430, #1428, #1427, #1426, #1425 , #1424). #1423 has not been merged as gapic-generator-java/1212 will invalidate this fix The found (and fixed) errors were: * the call to `xmllint` did not handle an empty `<modules>` list, causing the module addition function to fail in `generate-one` * missing `OPTARG` key `-x`, for commitish in `generate-one` * chore: undo unnecessary whitespace removal * fix: add module to pom - remove comment in pom and redundant folder spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centralizes the changes to be broken down by PRs such as #1423 #1425 #1427