Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt to new library_list.txt #1424

Merged
merged 4 commits into from
Jan 5, 2023

Conversation

diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Jan 4, 2023

  • passes googleapis commitish to generate-one.sh
  • has optional function for local development

BEGIN_COMMIT_OVERRIDE
chore(codegen): adapt to new library_list.txt
END_COMMIT_OVERRIDE

* passes googleapis commitish to `generate-one.sh`
* has optional function for local development
spring-cloud-generator/generate-all.sh Outdated Show resolved Hide resolved
spring-cloud-generator/generate-all.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegomarquezp diegomarquezp enabled auto-merge (squash) January 5, 2023 21:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@diegomarquezp diegomarquezp merged commit fd36d12 into main Jan 5, 2023
@diegomarquezp diegomarquezp deleted the spring-autogen-generate-all-update branch January 5, 2023 21:10
diegomarquezp added a commit that referenced this pull request Jan 7, 2023
The source of changes was moved to #1422 for which several PRs were made and
are now either closed or merged (#1430, #1428, #1427, #1426, #1425
, #1424). #1423 has not been merged as gapic-generator-java/1212 will
invalidate this fix

The found (and fixed) errors were:
* the call to `xmllint` did not handle an empty `<modules>` list,
causing the module addition function to fail in `generate-one`
* missing `OPTARG` key `-x`, for commitish in `generate-one`
diegomarquezp added a commit that referenced this pull request Jan 7, 2023
Initially brought by #1424, intended to handle a dev-env worflow that
was later deleted (do `mvn install` in root). This is now unnecessary.
diegomarquezp added a commit that referenced this pull request Jan 9, 2023
…h` (#1438)

* chore: remove unnecessary optarg handling in `generate-library-list.sh`

Initially brought by #1424, intended to handle a dev-env worflow that
was later deleted (do `mvn install` in root). This is now unnecessary.

* fix: remove correct optargs, restore incorrectly removed optargs
diegomarquezp added a commit that referenced this pull request Jan 13, 2023
* fix: after merging breakdown of #1407

The source of changes was moved to #1422 for which several PRs were made and
are now either closed or merged (#1430, #1428, #1427, #1426, #1425
, #1424). #1423 has not been merged as gapic-generator-java/1212 will
invalidate this fix

The found (and fixed) errors were:
* the call to `xmllint` did not handle an empty `<modules>` list,
causing the module addition function to fail in `generate-one`
* missing `OPTARG` key `-x`, for commitish in `generate-one`

* chore: undo unnecessary whitespace removal

* fix: add module to pom - remove comment in pom and redundant folder spec
diegomarquezp added a commit that referenced this pull request Jan 20, 2023
* feat: adapt to new library_list.txt

* passes googleapis commitish to `generate-one.sh`
* has optional function for local development

* chore: optional arg to do maven install in root folder

* chore: remove unnecessary dev env code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants