Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary optarg handling in generate-library-list.sh #1438

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

diegomarquezp
Copy link
Contributor

Initially brought by #1424, intended to handle a dev-env workflow that was later deleted (do mvn install in root). This is now unnecessary.

Initially brought by #1424, intended to handle a dev-env worflow that
was later deleted (do `mvn install` in root). This is now unnecessary.
Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. I think this is the commit hash or tag from monorepo to start search on and still needed.
Not related to the deleted code you are pointing to.

@diegomarquezp
Copy link
Contributor Author

@zhumin8 , I incorrectly removed the optargs from generate-library-list.sh. I just pushed a deletion on the right file (generate-all.sh)

@diegomarquezp diegomarquezp requested a review from zhumin8 January 9, 2023 15:43
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@diegomarquezp diegomarquezp merged commit 90ea09a into main Jan 9, 2023
@diegomarquezp diegomarquezp deleted the revert-optargs-gen-library-list branch January 9, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants