-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(codegen): manual GH action to generate autoconfigs #1341
Conversation
Kudos, SonarCloud Quality Gate passed! |
Some libraries have stream-based endpoints for which some retry settings will expect non-existing methods. This adds a list of these libraries so they are not generated
The source of changes was moved to #1422 for which several PRs were made and are now either closed or merged (#1430, #1428, #1427, #1426, #1425 , #1424). #1423 has not been merged as gapic-generator-java/1212 will invalidate this fix The found (and fixed) errors were: * the call to `xmllint` did not handle an empty `<modules>` list, causing the module addition function to fail in `generate-one` * missing `OPTARG` key `-x`, for commitish in `generate-one`
@diegomarquezp After syncing the changes from main, would the only expected file change in this PR be (Also dropping a side note for when you merge to update prefix to something like |
@emmileaf yes, the only other altered files besides the gh script were some |
Gotcha, thanks & LGTM! |
Apologies - just going to quickly edit the PR prefix before auto-squash-merging this! (Since this is more procedural and we don't intend it to be picked up as a releasable unit) |
Kudos, SonarCloud Quality Gate passed! |
No description provided.