Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codegen): manual GH action to generate autoconfigs #1341

Merged
merged 107 commits into from
Jan 25, 2023

Conversation

diegomarquezp
Copy link
Contributor

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Some libraries have stream-based endpoints for which some retry
settings will expect non-existing methods. This adds a list of these
libraries so they are not generated
The source of changes was moved to #1422 for which several PRs were made and
are now either closed or merged (#1430, #1428, #1427, #1426, #1425
, #1424). #1423 has not been merged as gapic-generator-java/1212 will
invalidate this fix

The found (and fixed) errors were:
* the call to `xmllint` did not handle an empty `<modules>` list,
causing the module addition function to fail in `generate-one`
* missing `OPTARG` key `-x`, for commitish in `generate-one`
@emmileaf
Copy link
Contributor

@diegomarquezp After syncing the changes from main, would the only expected file change in this PR be .github/workflows/generateAutoConfigs.yaml?

(Also dropping a side note for when you merge to update prefix to something like chore(codegen): - thanks!)

@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Jan 25, 2023

@emmileaf yes, the only other altered files besides the gh script were some chmods I did and a set -e I added. Both are optional changes I can include in the sanity check PR (or maybe a different one for the file modifiers). The PR now only has the GH action

@diegomarquezp diegomarquezp enabled auto-merge (squash) January 25, 2023 18:36
@emmileaf
Copy link
Contributor

@emmileaf yes, the only other altered files besides the gh script were some chmods I did and a set -e I added. Both are optional changes I can include in the sanity check PR (or maybe a different one for the file modifiers). The PR now only has the GH action

Gotcha, thanks & LGTM!

@emmileaf emmileaf disabled auto-merge January 25, 2023 18:38
@emmileaf
Copy link
Contributor

Apologies - just going to quickly edit the PR prefix before auto-squash-merging this! (Since this is more procedural and we don't intend it to be picked up as a releasable unit)

@emmileaf emmileaf changed the title feat: manual GH action to generate autoconfigs chore(codegen): manual GH action to generate autoconfigs Jan 25, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@emmileaf emmileaf merged commit 0c43663 into main Jan 25, 2023
@emmileaf emmileaf deleted the gh-generate-autoconf branch January 25, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants