Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] test: update sonar analysis exclusions #1853

Closed
wants to merge 7 commits into from

Conversation

emmileaf
Copy link
Contributor

@emmileaf emmileaf commented May 15, 2023

Opening a PR to troubleshoot failing sonar checks on main: details, after merging exclusion update from
#1816

Something about the glob pattern is not working as intended, and a recently added starter module in spring-cloud-previews is still picked up as in scope for analysis.

@emmileaf emmileaf force-pushed the sonar-exclusion-patch branch from 14b28ea to 845316b Compare May 15, 2023 19:47
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

4.9% 4.9% Coverage
75.5% 75.5% Duplication

@emmileaf
Copy link
Contributor Author

Closing as this approach (having unit tests alongside generated modules) is superseded by showcase testing setup in #1957.

@emmileaf emmileaf closed this Jul 10, 2023
@emmileaf emmileaf deleted the sonar-exclusion-patch branch July 10, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant