test: revert back to blanket sonar exclusion on spring-cloud-previews #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
meltsufin
approved these changes
May 15, 2023
| @@ -75,7 +75,7 @@ | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <integration-test.pattern>**/*IntegrationTest*</integration-test.pattern> | |||
| <!-- exclude preview module code from sonar cloud analysis --> | |||
| <sonar.exclusions>spring-cloud-previews/!(google-cloud-language-spring-starter)/**</sonar.exclusions> | |||
There was a problem hiding this comment.
Maybe you needed to escape the - with \-?
There was a problem hiding this comment.
Oh possibly...my other suspicion is that maybe /** only matches directories, and /**/* is still needed to match files?
Retrying this change in #1853, but will merge this revert for now. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the sonar exclusion change from #1816 to unblock CI.
I must have missed something in the exclusion glob pattern, and sonar analysis failed on main after merge (details). Seems like the analysis is picking up on code from generated modules (new in last 30 days: google-cloud-dataproc-metastore-spring-starter) when they intend to be excluded.
Going to verify this configuration out a bit more on a branch and retry the change (or possibly relocate the tests as suggested).