-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adoptopenjdk base image is deprecated and add support for Java 17 #3483
Comments
Thanks for bringing this to our attention. |
We should take this opportunity to add support for Java 17. (Basically, auto-detect Java 17 and use Temurin 17 as the default base image in that case.) |
Temurin doesn't ship a 17 jre https://blog.adoptium.net/2021/10/jlink-to-produce-own-runtime/ |
That makes me sad. I wonder if we have to choose a different vendor for Java 17. Spring Boot (Paketo Buildpakcs) uses BellSoft Libercia. |
Azul Zulu is also a serious contender. I am leaning toward it for Java 17. |
Another issue: currently ASM can't examine bytecode of newer Java versions, so this also needs to be taken care of. You can check a workaround in the linked Stack Overflow answer. UPDATE: we have a dependabot upgrading versions, so the HEAD already has the ASM version that can handle Java 17 bytecode. |
Perhaps we should create a new issue investigating if we can try/catch that issue and log possible solutions in the future. Solutions being upgrade jib if not on latest, consider reporting a bug |
Actually temurin now ships JREs: https://blog.adoptium.net/2021/12/eclipse-temurin-jres-are-back/ |
@racevedoo oh, glad that they changed their mind. Thanks for letting us know. |
Fortunately, we haven't released the base image change (#3491). For consistency, we will use Temurin for Java 17 as well. |
Hello, |
Just merged #3552, which will make Jib use Eclipse Temurin for all Java versions. Will release a new version next week. But if you have a build failure due to ASM, there is a workaround. If the problem is about Jib not automatically selecting a working base image for Java 17, you can always configure |
default_base_image.md (first sentence) still links to the deprecated AdoptOpenJdk image. It also mentions the project being renamed to Adoptium, but now it's already called Eclipse Temurin. Should probably be updated to prevent confusion. |
@fblampe the doc will be updated once there's a new release. |
Might be worth checking out eclipse-temurin or another alternative
The text was updated successfully, but these errors were encountered: