Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ about unsupported Java version and throw error with more helpful message #3499

Merged
merged 6 commits into from
Nov 11, 2021

Conversation

chanseokoh
Copy link
Member

@chanseokoh chanseokoh commented Nov 10, 2021

@chanseokoh chanseokoh requested a review from a team November 10, 2021 17:24
@chanseokoh chanseokoh changed the title Add FAQ about unsupported Java version Add FAQ about unsupported Java version and throw error with more helpful message Nov 10, 2021
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
Co-authored-by: Tomo Suzuki <suztomo@gmail.com>
@google-cla

This comment has been minimized.

@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 11, 2021
Co-authored-by: Tomo Suzuki <suztomo@gmail.com>
@google-cla

This comment has been minimized.

1 similar comment
@google-cla

This comment has been minimized.

@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 11, 2021
@google-cla

This comment has been minimized.

@google-cla
Copy link

google-cla bot commented Nov 11, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Nov 11, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@chanseokoh
Copy link
Member Author

chanseokoh commented Nov 11, 2021

FTR: the reason for the CLA bot complaining is due to the code contributed by @suztomo, who is a Googler. We are good.

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chanseokoh chanseokoh merged commit 6b43bdc into master Nov 11, 2021
@chanseokoh chanseokoh deleted the asm-unsupported-version branch November 11, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants