Change default base images from AdoptOpenJDK to Eclipse Adoptium Eclipse Temurin (for Java 8 and 11) and use Azul Zulu (for Java 17) #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanseokoh
changed the title
mpeddada1
reviewed
Nov 8, 2021
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/jar/JarFiles.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessorTest.java
Outdated
Show resolved
Hide resolved
|
Ready for review. |
mpeddada1
approved these changes
Nov 9, 2021
...rc/integration-test/java/com/google/cloud/tools/jib/gradle/SingleProjectIntegrationTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessorTest.java
Show resolved
Hide resolved
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/jar/JarFiles.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
mpeddada1
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration for #3483.
Eclipse Temurin by Adoptium is the new name of AdoptOpenJDK. For Java 8 and 11, we switch
adoptopenjdktoeclipse-temurin.For Java 17, we use
azul/zulu-openjdk:17-jre.Going forward at some point, I wonder if we should just use the latest LTS Java version all versions instead of matching previous LTS versions.