Skip to content

Commit

Permalink
fix (partial): [V2] TestDockerDebug failing #7170 (#7189)
Browse files Browse the repository at this point in the history
* fix: added missing items from PR 6528 for DockerDebug

* fix: removed GO version pinning not intended in this PR
  • Loading branch information
dhodun authored Mar 15, 2022
1 parent d5f072e commit e304f75
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
11 changes: 11 additions & 0 deletions integration/testdata/debug/skaffold.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,14 @@ profiles:
# context: netcore
# buildpacks:
# builder: "gcr.io/buildpacks/builder:v1"
- name: docker
patches:
- op: remove
path: /deploy/kubectl
build:
artifacts:
- image: skaffold-debug-nodejs
context: nodejs
deploy:
docker:
images: [skaffold-debug-nodejs]
2 changes: 1 addition & 1 deletion pkg/skaffold/schema/latest/v2/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ type DeployConfig struct {
// time for hybrid workflows.
type DeployType struct {
// DockerDeploy *alpha* uses the `docker` CLI to create application containers in Docker.
DockerDeploy *DockerDeploy `yaml:"-,omitempty"`
DockerDeploy *DockerDeploy `yaml:"docker,omitempty"`

// HelmDeploy *beta* uses the `helm` CLI to apply the charts to the cluster.
HelmDeploy *HelmDeploy `yaml:"helm,omitempty"`
Expand Down

0 comments on commit e304f75

Please sign in to comment.