Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (partial): [V2] TestDockerDebug failing #7170 #7189

Merged

Conversation

dhodun
Copy link
Contributor

@dhodun dhodun commented Mar 14, 2022

Partially Fixes: #7030

Description:

Adds back some missing integration test code and adds Docker Deployer to the schema. These changes seem to be missing from large Docker Debugger PR: #6528

Follow Up:

While this may fully fix the bug as intended, the integration is either not fully passing or is passing in error. skaffold debug while running locally or in minikube is still blocked by: #7104

This PR unblocks the skaffold build part of the test:

skaffold.Build("-p", "docker").InDir("testdata/debug").RunOrFail(t)

The skaffold debug part of the test is still blocked.

skaffold.Debug("-p", "docker").InDir("testdata/debug").RunBackground(t)

However, I am able to run the test locally and it passes, even though it appears to not deploy anything and has the expected "failed to resolve digest" error:

=== RUN   TestDockerDebug
=== RUN   TestDockerDebug/debug_docker_deployment
time="2022-03-14T15:10:57-04:00" level=info msg="Running [skaffold build --default-repo gcr.io/k8s-skaffold -p docker] in testdata/debug"
time="2022-03-14T15:10:59-04:00" level=info msg="Ran [skaffold build --default-repo gcr.io/k8s-skaffold -p docker] in 1.788 second"
time="2022-03-14T15:10:59-04:00" level=info msg="Running [skaffold debug --default-repo gcr.io/k8s-skaffold -p docker] in testdata/debug"
time="2022-03-14T15:10:59-04:00" level=warning msg="failed to detect active kubernetes cluter node platform. Specify the correct build platform in the `skaffold.yaml` file or using the `--platform` flag" subtask=-1 task=DevLoop
time="2022-03-14T15:10:59-04:00" level=warning msg="k8s/*.yaml did not match any file" subtask=-1 task=DevLoop
failed to resolve the digest of skaffold-debug-nodejs:07ae88f3209c4648d7cb9f9b8b87e0813c061525d1c6102980b56999730f4fd3: does the image exist remotely?
time="2022-03-14T15:11:01-04:00" level=info msg="Ran [skaffold debug --default-repo gcr.io/k8s-skaffold -p docker] in 1.804 second"
time="2022-03-14T15:11:01-04:00" level=info msg="Running [skaffold delete --default-repo gcr.io/k8s-skaffold -p docker] in testdata/debug"
time="2022-03-14T15:11:01-04:00" level=info msg="Ran [skaffold delete --default-repo gcr.io/k8s-skaffold -p docker] in 6.569188ms"
--- PASS: TestDockerDebug (3.94s)
    --- PASS: TestDockerDebug/debug_docker_deployment (3.94s)
PASS
ok      github.com/GoogleContainerTools/skaffold/integration    (cached)

@dhodun dhodun requested a review from a team as a code owner March 14, 2022 19:24
@dhodun dhodun requested review from MarlonGamez and removed request for a team March 14, 2022 19:24
@dhodun dhodun requested a review from gsquared94 March 14, 2022 19:25
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v2-v1.36.0@00c4877). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             v2-v1.36.0    #7189   +/-   ##
=============================================
  Coverage              ?   67.62%           
=============================================
  Files                 ?      557           
  Lines                 ?    26552           
  Branches              ?        0           
=============================================
  Hits                  ?    17956           
  Misses                ?     7308           
  Partials              ?     1288           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✅

@dhodun dhodun force-pushed the issue_7030_v2_milestone branch from e83c5b5 to 40bd98d Compare March 15, 2022 17:27
@tejal29 tejal29 merged commit e304f75 into GoogleContainerTools:v2-v1.36.0 Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants