fix (partial): [V2] TestDockerDebug failing #7170 #7189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes: #7030
Description:
Adds back some missing integration test code and adds Docker Deployer to the schema. These changes seem to be missing from large Docker Debugger PR: #6528
Follow Up:
While this may fully fix the bug as intended, the integration is either not fully passing or is passing in error.
skaffold debug
while running locally or in minikube is still blocked by: #7104This PR unblocks the
skaffold build
part of the test:skaffold/integration/debug_test.go
Line 127 in aa2d9b9
The
skaffold debug
part of the test is still blocked.skaffold/integration/debug_test.go
Line 129 in aa2d9b9
However, I am able to run the test locally and it passes, even though it appears to not deploy anything and has the expected "failed to resolve digest" error: