Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activating a profile triggers a warning #1688

Closed
dgageot opened this issue Feb 22, 2019 · 7 comments · Fixed by #1693
Closed

Activating a profile triggers a warning #1688

dgageot opened this issue Feb 22, 2019 · 7 comments · Fixed by #1693
Assignees
@dgageot
Labels
area/profiles area/tekton kind/bug Something isn't working priority/p1 High impact feature/bug.

Comments

@dgageot
Copy link
Contributor

dgageot commented Feb 22, 2019 

$ skaffold build -p anyprofile
WARN[0000] unknown field type in profile overlay: ptr. falling back to original config values

This is because the code that merges profiles into main configuration doesn't handle some recent fields that are pointers, such as ExecutionEnvironment *ExecutionEnvironment.
priyawadhwa pushed a commit to priyawadhwa/skaffold-1 that referenced this issue Feb 25, 2019
Handle pointers in profile overlay
3004d1f 
Return original values, or values in profile, upon encoutering a
pointer. This should fix a warning generated by the new
*ExecutionEnvironment pointer in the BuildConfig. Also adds unit tests
to check this functionality.

Fixes GoogleContainerTools#1688
@priyawadhwa priyawadhwa mentioned this issue Feb 25, 2019
Merged
@demisx
Copy link
Contributor

demisx commented Aug 20, 2019 •
edited
Loading

I am seeing this warning in the latest skaffold v0.36 on Mac Os Mojave 10.14.6 running any skaffold command that references a profile:

WARN[0000] unknown field type in profile overlay: int. falling back to original config values

@kurczynski
Copy link

I'm also seeing this in version 0.36 on Fedora 30:

WARN[0000] unknown field type in profile overlay: int. falling back to original config values

@bjesus
Copy link

bjesus commented Aug 26, 2019

Also seeing this on ArchLinux with Skaffold 0.36. Perhaps this issue should be reopened? @dgageot

@nkubala nkubala reopened this Aug 26, 2019
@nkubala nkubala added the priority/p1 High impact feature/bug. label Aug 26, 2019
@dgageot
Copy link
Contributor Author

dgageot commented Aug 27, 2019

@demisx @kurczynski @bjesus Could you provide a sample that shows the issue? Or maybe it happens with one of our samples?

@dgageot dgageot self-assigned this Aug 27, 2019
@dgageot
Copy link
Contributor Author

dgageot commented Aug 27, 2019

This has been fixed in 83b0f45, just after the 0.36 release freeze.

@dgageot dgageot closed this as completed Aug 27, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Aug 27, 2019
@dgageot
We must handle every profile field type
5a79118 
This would have caught GoogleContainerTools#1688

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot mentioned this issue Aug 27, 2019
Merged
@demisx
Copy link
Contributor

demisx commented Aug 27, 2019

Confirming that I don't see this error on the latest bleeding edge. Just one more step closer to being perfect! Thank you, team.

dgageot added a commit to dgageot/skaffold that referenced this issue Aug 28, 2019
@dgageot
We must handle every profile field type
0c3e558 
This would have caught GoogleContainerTools#1688

Signed-off-by: David Gageot <david@gageot.net>
@nkubala
Copy link
Contributor

nkubala commented Aug 28, 2019

whoops, didn't realize my fix didn't make it into the release. thanks for investigating @dgageot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
area/profiles area/tekton kind/bug Something isn't working priority/p1 High impact feature/bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle pointers in profile overlay priyawadhwa/skaffold-1
6 participants
@bjesus @dgageot @balopat @demisx @kurczynski @nkubala