Handle pointers in profile overlay #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return original values, or values in profile, upon encoutering a pointer. This should fix a warning generated by the new *ExecutionEnvironment pointer in the BuildConfig. Also adds unit tests to check this functionality. Fixes GoogleContainerTools#1688
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1693 +/- ##
==========================================
- Coverage 46.54% 46.52% -0.02%
==========================================
Files 125 125
Lines 5657 5661 +4
==========================================
+ Hits 2633 2634 +1
- Misses 2751 2754 +3
Partials 273 273
Continue to review full report at Codecov.
|
dgageot
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return original values, or values in profile, upon encoutering a
pointer. This should fix a warning generated by the new
*ExecutionEnvironment pointer in the BuildConfig. Also adds unit tests
to check this functionality.
Fixes #1688